[asterisk-dev] [Code Review] HTTP Digest authentication

[Tilghman Lesher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/223/#review697
-----------------------------------------------------------


Reviewing this, myself, first.


/trunk/include/asterisk/http.h
<http://reviewboard.digium.com/r/223/#comment1790>

    Oops.



/trunk/main/ast_expr2.h
<http://reviewboard.digium.com/r/223/#comment1791>

    Another oops.



/trunk/main/astobj2.c
<http://reviewboard.digium.com/r/223/#comment1793>

    Debugging, to be removed.



/trunk/main/http.c
<http://reviewboard.digium.com/r/223/#comment1796>

    Add a note that ast_http_send() frees http_header



/trunk/main/http.c
<http://reviewboard.digium.com/r/223/#comment1797>

    Again, ast_http_send() frees out.



/trunk/main/http.c
<http://reviewboard.digium.com/r/223/#comment1800>

    free both before returning.  One allocation could succeed while the other fails.



/trunk/main/http.c
<http://reviewboard.digium.com/r/223/#comment1801>

    Ditto



/trunk/main/manager.c
<http://reviewboard.digium.com/r/223/#comment1802>

    Ugh, leading spaces in new code.


- Tilghman


On 2009-04-14 18:11:09, Tilghman Lesher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/223/
> -----------------------------------------------------------
> 
> (Updated 2009-04-14 18:11:09)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Enable the use of HTTP Digest authentication when using the AMI HTTP interface.
> 
> 
> This addresses bug 10961.
>     http://bugs.digium.com/view.php?id=10961
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/http.h 187763 
>   /trunk/include/asterisk/utils.h 187763 
>   /trunk/main/ast_expr2.h 187763 
>   /trunk/main/ast_expr2.c 187763 
>   /trunk/main/astobj2.c 187763 
>   /trunk/main/http.c 187763 
>   /trunk/main/manager.c 187763 
>   /trunk/main/utils.c 187763 
>   /trunk/res/res_http_post.c 187763 
>   /trunk/res/res_phoneprov.c 187763 
> 
> Diff: http://reviewboard.digium.com/r/223/diff
> 
> 
> Testing
> -------
> 
> Lots of testing with fairly large files; all issues found were resolved.
> 
> 
> Thanks,
> 
> Tilghman
> 
>