[asterisk-dev] [Code Review] National prefix inserted even when caller ID not available

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/220/#review689
-----------------------------------------------------------

Ship it!


This looks fine, assuming that you did test it.  Your "testing done" section is blank.

- Russell


On 2009-04-13 12:09:42, David Vossel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/220/
> -----------------------------------------------------------
> 
> (Updated 2009-04-13 12:09:42)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> When the caller ID is restricted, the expected behavior is for the caller id to be blank.  In chan_dahdi, the national prefix is placed onto the callers number even if its restricted (empty) causing the caller id to be the national prefix rather than blank.  
> 
> For example. national prefix is 0, caller number is blank, caller id displays '0' rather than nothing.
> log message of issue: [Jul 30 09:07:11] VERBOSE[3843] logger.c:     -- Accepting call from '0' to '1237' on channel 0/1, span 1
> 
> Solution: check to see if callingnum is blank before calling apply_plan_to_number() function which applies the nation_prefix. 
> 
> 
> This addresses bug 13207.
>     http://bugs.digium.com/view.php?id=13207
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_dahdi.c 188070 
> 
> Diff: http://reviewboard.digium.com/r/220/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David
> 
>