[asterisk-dev] [Code Review] Add CCBS/CCNR and enhanced COLP features to chan_misdn.

[rmudgett at digium.com]

> On 2009-04-10 15:21:27, Russell Bryant wrote:
> > /trunk/channels/chan_misdn.c, lines 278-281
> > <http://reviewboard.digium.com/r/218/diff/1/?file=4123#file4123line278>
> >
> >     After converting to the linked list macros.  The lock declaration and initialization will be included for you with AST_LIST_HEAD_STATIC().

done


> On 2009-04-10 15:21:27, Russell Bryant wrote:
> > /trunk/channels/chan_misdn.c, lines 154-155
> > <http://reviewboard.digium.com/r/218/diff/1/?file=4123#file4123line154>
> >
> >     You can use AST_MUTEX_DEFINE_STATIC() here instead and avoid mutex_init() / mutex_destroy()

done


> On 2009-04-10 15:21:27, Russell Bryant wrote:
> > /trunk/channels/chan_misdn.c, lines 172-173
> > <http://reviewboard.digium.com/r/218/diff/1/?file=4123#file4123line172>
> >
> >     We have some linked list helper macros in linkedlists.h.  Would you mind converting this over to use them?

done, please check to make sure that I converted them correctly.


> On 2009-04-10 15:21:27, Russell Bryant wrote:
> > /trunk/channels/chan_misdn.c, lines 231-242
> > <http://reviewboard.digium.com/r/218/diff/1/?file=4123#file4123line231>
> >
> >     It looks like you have some fields that could be made into bit fields.

decline.  Bit-fields are notoriously non-portable and can be code intensive for the compiler to implement.  The resulting code bloat can make the reduction in the structure size not worth it.


- rmudgett


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/218/#review680
-----------------------------------------------------------


On 2009-04-10 15:03:46, rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/218/
> -----------------------------------------------------------
> 
> (Updated 2009-04-10 15:03:46)
> 
> 
> Review request for Asterisk Developers, Russell Bryant and Mark Michelson.
> 
> 
> Summary
> -------
> 
> This diff adds the following features to chan_misdn:
> * CCBS/CCNR Party A support for PTMP and PTP modes.
> * Enhances COLP support for call diversion and explicit call transfer.
> 
> These enhanced features require a modified version of mISDN.
> 
> The latest modified mISDN v1.1.x based version is available at:
> http://svn.digium.com/svn/thirdparty/mISDN/trunk
> http://svn.digium.com/svn/thirdparty/mISDNuser/trunk
> 
> Taged versions of the modified mISDN code are available under:
> http://svn.digium.com/svn/thirdparty/mISDN/tags
> http://svn.digium.com/svn/thirdparty/mISDNuser/tags
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 187806 
>   /trunk/channels/chan_misdn.c 187806 
>   /trunk/channels/misdn/chan_misdn_config.h 187806 
>   /trunk/channels/misdn/ie.c 187806 
>   /trunk/channels/misdn/isdn_lib.h 187806 
>   /trunk/channels/misdn/isdn_lib.c 187806 
>   /trunk/channels/misdn/isdn_lib_intern.h 187806 
>   /trunk/channels/misdn/isdn_msg_parser.c 187806 
>   /trunk/channels/misdn_config.c 187806 
>   /trunk/configs/misdn.conf.sample 187806 
> 
> Diff: http://reviewboard.digium.com/r/218/diff
> 
> 
> Testing
> -------
> 
> Digium's Product Quality department has tested a similar version of these enhancements. In addition, we know of a customer who has been testing these changes.
> 
> There is a test cli command that can be conditionally compiled into the code by defining CCBS_TEST_MESSAGES in chan_misdn.c.  The test command allows you to send canned facility messages that I used to test the encoding and decoding routines in mISDN.
> 
> misdn send facility test (<port> [<msg#>]) | (<channel-name> <msg#>)
> 
> 
> Thanks,
> 
> rmudgett
> 
>