[asterisk-dev] [Code Review] Makefile now specifies whether or not DAHDI hardware was found

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/216/#review676
-----------------------------------------------------------



/tools/trunk/Makefile
<http://reviewboard.digium.com/r/216/#comment1769>

    Nice work, this is an interesting approach.  I have some comments for you.
    
    First, with the conditional statements, you could make it such that you only check DAHDI_HW once.
    
    ifeq (,$(DAHDI_HW))
    ...
    else
    ...
    endif
    
    Also, with the way this is written, the xpp/dahdi_hardware script will be executed in a lot of cases where it doesn't need to be.  For example, if you run "make clean", it will be executed, even though the result will not be used.
    
    What if you just changed the dahdi_hardware tool to print out a message if no hardware was found?


- Russell


On 2009-04-08 16:50:04, dbrooks wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/216/
> -----------------------------------------------------------
> 
> (Updated 2009-04-08 16:50:04)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This is a patch that allows the DAHDI Makefile to announce to the user whether or not it found DAHDI hardware. Prior to this patch, if DAHDI hardware was not found, "make config" would announce: "I think that the DAHDI hardware you have on your system is: " and stop there.
> 
> 
> This addresses bug 0014792.
>     http://bugs.digium.com/view.php?id=0014792
> 
> 
> Diffs
> -----
> 
>   /tools/trunk/Makefile 6274 
> 
> Diff: http://reviewboard.digium.com/r/216/diff
> 
> 
> Testing
> -------
> 
> This patch was tested on x86_64-linux-gnu, and GNU Make 3.81.
> 
> 
> Thanks,
> 
> dbrooks
> 
>