[asterisk-dev] [Code Review] Add technology independent static control

[Kaloyan Kovachev]

On Wed, 01 Apr 2009 14:15:37 -0000, Russell Bryant wrote
> > On 2009-04-01 09:11:29, Jared Smith wrote:
> > > /trunk/funcs/func_static.c, line 43
> > > <http://reviewboard.digium.com/r/214/diff/1/?file=3995#file3995line43>
> > >
> > >     This looks funny... but I guess it's valid if it doesn't take any
parameters.
> 
> Yeah, no params.
> 
> > On 2009-04-01 09:11:29, Jared Smith wrote:
> > > /trunk/funcs/func_static.c, line 52
> > > <http://reviewboard.digium.com/r/214/diff/1/?file=3995#file3995line52>
> > >
> > >     Shouldn't we make the DTMF sequences customizable in features.conf?
 Or via parameters?  I'd hate to go to do a blind transfer and accidentally
put static on the line instead... on second thought, I'd love to do that!
> 

The same problem is with the VOLUME() itself - take a look at
http://bugs.digium.com/view.php?id=14621 and
http://bugs.digium.com/view.php?id=14621#101337 is also valid here. Having
several functions using the same DTMF sequences and without any way to change
them (not touching the code) will cause lots of problems and if 1.6.1 is out
with harcoded sequences there will be also backward compatibality isues when
fix is attemted, because peoples existing dialplans do not set the key
explicitly, which they should

> Yeah, that would be nice.  I basically followed suit with what func_volume
does.  Honestly, I'm too lazy to add the options.  :-)
> 
> > On 2009-04-01 09:11:29, Jared Smith wrote:
> > > /trunk/funcs/func_static.c, line 86
> > > <http://reviewboard.digium.com/r/214/diff/1/?file=3995#file3995line86>
> > >
> > >     Is this really white noise?  What about an option for pink noise as
well?
> 
> You're right.  I have fixed the comment to accurately state that it's
turquoise noise.
> 
> > On 2009-04-01 09:11:29, Jared Smith wrote:
> > > /trunk/funcs/func_static.c, line 137
> > > <http://reviewboard.digium.com/r/214/diff/1/?file=3995#file3995line137>
> > >
> > >     This notice is not descriptive enough... If I got a warning that
said "bad direction", I'd think it was the GPS in my car telling me to make
another U-turn.
> 
> Oops, this was left over debugging code.  Removed.
> 
> > On 2009-04-01 09:11:29, Jared Smith wrote:
> > > /trunk/funcs/func_static.c, line 187
> > > <http://reviewboard.digium.com/r/214/diff/1/?file=3995#file3995line187>
> > >
> > >     Shouldn't this audiohook be named "Static" or "White Noise" instead
of "Volume"?
> 
> Oops.  Now you can tell what I was stealing some code from!  Fixed.
> 
> - Russell
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/214/#review662
> -----------------------------------------------------------
> 
> On 2009-04-01 09:10:10, Russell Bryant wrote:
> > 
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > http://reviewboard.digium.com/r/214/
> > -----------------------------------------------------------
> > 
> > (Updated 2009-04-01 09:10:10)
> > 
> > 
> > Review request for Asterisk Developers.
> > 
> > 
> > Summary
> > -------
> > 
> > This is the feature that you have all been waiting for.
> > 
> > This new function allows you to introduce static into a phone call.  The
common use case is as an excuse to get off of an annoying phone call.  If
someone won't stop talking, just start increasing the static until you can't
hear each other anymore.  Problem solved!
> > 
> > 
> > Diffs
> > -----
> > 
> >   /trunk/funcs/func_static.c PRE-CREATION 
> > 
> > Diff: http://reviewboard.digium.com/r/214/diff
> > 
> > 
> > Testing
> > -------
> > 
> > exten => 1234,1,Set(STATIC()=0) ; Set up STATIC() so I can control it via
DTMF during the call
> > exten => 1234,N,Dial(SIP/1234)  ; When 1234 gets annoying, start pressing
'*' to increase static
> > 
> > I tested an extension like the above and verified that I could increase
and decrease the static at will.
> > 
> > 
> > Thanks,
> > 
> > Russell
> > 
> >
> 
> _______________________________________________
> --Bandwidth and Colocation Provided by http://www.api-digital.com--
> 
> asterisk-dev mailing list
> To UNSUBSCRIBE or update options visit:
>    http://lists.digium.com/mailman/listinfo/asterisk-dev