[asterisk-dev] [Code Review] SIP Re-invite Glare and 491 Madness...

[Olle E. Johansson]

While I understand what you're trying to do, the whole situation seems  
like we're continuing to add bad patches to something with the wrong  
architecture from start. Suddenly, we have cseq in at least four places:

  - last invite cseq
  - last non-invite cseq
  - glare cseq
  - the stored packet's (initreq) cseq

Is this really the proper way to go? While this might be the most  
light-weight patch for older releases, I suggest that someone spends  
some time on finding a proper architecture for trunk. The spagetthi  
code in chan_sip is beginning to look more and more like overcooked  
lasagna.

David - thank you for analysing the situation. This has really been a  
hairy problem for a long time.

/O