[asterisk-dev] zap-bri spantype and signalling [was: Re: [svn-commits] sruffell: linux/trunk r5196 - /linux/trunk/drivers/dahdi/wcb4xxp/base.c]

[Tzafrir Cohen]

On Fri, Oct 31, 2008 at 10:23:52PM -0000, SVN commits to the Digium repositories wrote:
> Author: sruffell
> Date: Fri Oct 31 17:23:52 2008
> New Revision: 5196
> 
> URL: http://svn.digium.com/view/dahdi?view=rev&rev=5196
> Log:
> Changing the spantype to indicate whether it is a TE or NT BRI port.
> 
> Modified:
>     linux/trunk/drivers/dahdi/wcb4xxp/base.c
> 
> Modified: linux/trunk/drivers/dahdi/wcb4xxp/base.c
> URL: http://svn.digium.com/view/dahdi/linux/trunk/drivers/dahdi/wcb4xxp/base.c?view=diff&rev=5196&r1=5195&r2=5196
> ==============================================================================
> --- linux/trunk/drivers/dahdi/wcb4xxp/base.c (original)
> +++ linux/trunk/drivers/dahdi/wcb4xxp/base.c Fri Oct 31 17:23:52 2008
> @@ -2094,7 +2094,7 @@
>  
>  		bspan->span.irq = b4->pdev->irq;
>  		bspan->span.pvt = bspan;
> -		bspan->span.spantype = "BRI";
> +		bspan->span.spantype = (bspan->te_mode) ? "TE" : "NT";
>  		bspan->span.offset = i;
>  		bspan->span.channels = WCB4XXP_CHANNELS_PER_SPAN;
>  		bspan->span.flags = 0;

(The "BRI" there was my speculation based on the value from the xpp BRI
module)

I don't understand the point of using "NT" and "TE" there. Let's look at
what other modules have there:

linux/trunk/drivers/dahdi$ grep spantype *.c */*.c | grep -v ==
dahdi-base.c:           if (spans[i]->spantype)
dahdi-base.c:
dahdi_copy_string(stack.spaninfo.spantype, spans[i]->spantype,
sizeof(stack.spaninfo.spantype));
tor2.c:                 tor->spans[x].spantype = "T1";
tor2.c:                 tor->spans[x].spantype = "E1";
wct1xxp.c:              wc->span.spantype = "E1";
wct1xxp.c:              wc->span.spantype = "T1";
wcte11xp.c:     int spantype;
wcte11xp.c:     if (alreadyrunning && (wc->spantype != TYPE_E1))
wcte11xp.c:             wc->span.spantype = "E1";
wcte11xp.c:             wc->span.spantype = "T1";
wcte11xp.c:             if (wc->spantype != TYPE_E1) {
wcte11xp.c:                     wc->spantype = TYPE_E1;
wcte11xp.c:                     wc->spantype = TYPE_T1;
wcte11xp.c:                     wc->spantype = TYPE_T1;
wcte11xp.c:                     wc->spantype = TYPE_E1;
wcb4xxp/base.c:         bspan->span.spantype = (bspan->te_mode) ? "TE" :
"NT";
wct4xxp/base.c: int spantype;           /* card type, T1 or E1 or J1 */
wct4xxp/base.c:         switch (ts->spantype) {
wct4xxp/base.c:                 ts->span.spantype = "T1";
wct4xxp/base.c:                 ts->span.spantype = "E1";
wct4xxp/base.c:                 ts->span.spantype = "J1";
wct4xxp/base.c:                 wc->tspans[x]->spantype = TYPE_E1;
wct4xxp/base.c:                         wc->tspans[x]->spantype =
TYPE_J1;
wct4xxp/base.c:                         wc->tspans[x]->spantype =
TYPE_T1;
wcte12xp/base.c:        if (alreadyrunning && (wc->spantype != TYPE_E1))
wcte12xp/base.c:                wc->span.spantype = "E1";
wcte12xp/base.c:                wc->span.spantype = "T1";
wcte12xp/base.c:                        wc->spantype = TYPE_E1;
wcte12xp/base.c:                        wc->spantype = TYPE_T1;
wcte12xp/base.c:                        wc->spantype = TYPE_T1;
wcte12xp/base.c:                        wc->spantype = TYPE_E1;
xpp/card_bri.c: xpd->span.spantype = "BRI";
xpp/card_fxo.c: xpd->span.spantype = "FXO";
xpp/card_fxs.c: xpd->span.spantype = "FXS";
xpp/card_pri.c: xpd->span.spantype =
pri_protocol_name(priv->pri_protocol);
xpp/xpp_dahdi.c:        /* span->spantype = "...."; set in
card_dahdi_preregistration() */


Another point: the BRI module currently does not claim to support
DAHDI_CONFIG_CCS . This means that a span line of the sort of:

  span=1,1,ccs,ami

won't work.

-- 
               Tzafrir Cohen
icq#16849755              jabber:tzafrir.cohen at xorcom.com
+972-50-7952406           mailto:tzafrir.cohen at xorcom.com
http://www.xorcom.com  iax:guest at local.xorcom.com/tzafrir