[asterisk-dev] [asterisk-commits] eliel: branch group/appdocsxml r151893 - in /team/group/appdocsxml: include/a...

[Eliel Sardañons]

Thanks, fixed, we didn't need those casts anymore.

On Tue, Oct 28, 2008 at 11:34 AM, Kevin P. Fleming <kpfleming at digium.com>wrote:

> Eliel Sardañons wrote:
>
> > Maybe we can discuss if it makes sense to do those typedefs
> > (ast_xml_text and ast_xml_attr). But the casting is being done on
> > ->AST_XML_NAME (actually on node->name this is because of a signedness
> > warning) and not when working with the typedefs ast_xml_attr and
> > ast_xml_text.
> > ->name is defined as xmlChar * (libxml2 implementation, maybe 'unsigned
> > char *' ??? didn't check it...).
>
> Well, that is some of it, but I also saw casting of 'paramtype' in pbx.c
>  which is an ast_xml_attr *. It's inconsistent though... in some places
> when it is being passed to ast_true() or ast_false() it is being cast to
>  'const char *' and in other places it is not being cast at all. Since
> it is typedef'd to char anyway, the casts really shouldn't be needed,
> but if they are then we need to figure out whether the typedefs are
> really providing any value.
>
> --
> Kevin P. Fleming
> Director of Software Technologies
> Digium, Inc. - "The Genuine Asterisk Experience" (TM)
>
>
> _______________________________________________
> --Bandwidth and Colocation Provided by http://www.api-digital.com--
>
> asterisk-dev mailing list
> To UNSUBSCRIBE or update options visit:
>   http://lists.digium.com/mailman/listinfo/asterisk-dev
>



-- 
Eliel Sardañons
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.digium.com/pipermail/asterisk-dev/attachments/20081028/daa49bae/attachment-0001.htm