[asterisk-dev] 1.2.28 patch - a minor point

[Tzafrir Cohen]

On Fri, Apr 25, 2008 at 04:23:49PM +0800, Dinesh Nair wrote:
> On Thu, 24 Apr 2008 11:39:43 +0200, Paul Hewlett wrote:
> 
> > Following the recent security alert, I applied the 1.2.28 patch to my 
> > source code. It now does not compile - it fails when trying to compile 
> > codecs/codec_ilbc.c - I note that the patch effectively zero-lengths all 
> > files in codecs/ilbc but not codec_ilbc.c. The Makefile in codecs 
> > directory tests for the existence of file ilbc/iLBC_decode.h which 
> > exists but is of zero length. I changed the Makefile from
> 

Consider applying just the diff to chan_iax from the patch of
1.2.27->1.2.28 .

Generating such a patch is easy:

  svn diff http://svn.digium.com/svn/asterisk/tags/1.2.27 \
           http://svn.digium.com/svn/asterisk/tags/1.2.28

Trim everything outside of channels/chan_iax and be done with it.

> there's a script in contrib/scripts called get_ilbc_source.sh which when
> run uses wget to populate codecs/ilbc independently. you'd probably need
> to pick up that script from the 1.2.28 tarball/svn and run it. 

And if you use Asterisk for a commercial purpose you should carefully
reivew the license attached to that ilbc code.

-- 
               Tzafrir Cohen
icq#16849755              jabber:tzafrir.cohen at xorcom.com
+972-50-7952406           mailto:tzafrir.cohen at xorcom.com
http://www.xorcom.com  iax:guest at local.xorcom.com/tzafrir