[asterisk-dev] ast_flags now uint64_t ? should it be reverted ?

[Luigi Rizzo]

Hi,
the following change modified ast_flags to uint64_t

	http://svn.digium.com/view/asterisk?view=rev&revision=75400

causing a rather massive change, both in-tree and to third party
code, all for the benefit of a single application, app_dial.c

I don't think this change is a good idea, partly because of the overall
increase in memory and processing time (especially on low-end boxes),
but mainly because it might open the way to hard-to-detect bugs
because of truncation in assignments.

I'd suggest to have this change reverted, and if that one application
(app_dial.c) needs a larger set of flags, consider storing some of
them in a different variable.

As an example, in app_dial.c, there is no reason to have
DIAL_STILLGOING and DIAL_NOFORWARDHTML stored together
with the various OPT_* flags. This can be fixed trivially.

(I would even claim that a dialplan app such as Dial(), with
some 30 different one-letter options, is a recipe for disaster
and misconfiguration, but that's another story...)

	cheers
	luigi