[asterisk-dev] [asterisk-commits] file: trunk r81345 - /trunk/main/event.c

[Russell Bryant]

Luigi Rizzo wrote:
> As far as i remember pointer arithmetic on "void *" is a gnu
> extension not guaranteed to work on all compilers.
> You should use char * to be standard compliant (even better,
> something like a NEXT_IE(x) macro that takes care of the
> conversion throughout the file.

I changed the pointer arithmetic on "void *" to use "char *" instead - trunk rev
81354.

> On passing i also wonder about the following:
> 
> - ast_event and ast_event_ie have exactly the same
>   structure, so is there a reason to use two definitions ?

The only reason I have for them being different is for clarity.  An event is an
ast_event that could have 0 or more information elements (ast_event_ie).  They
just ended up having the exact same structure.

-- 
Russell Bryant
Software Engineer
Digium, Inc.