[Asterisk-Dev] possible bug in app_dial.c ?

[Luigi Rizzo]

Hi,
i am not sure but this snippet of code in app_dial.c 1.188 looks
suspicious:

1.128     markster  432:  while (o) {
                    ..........................
                    539:              }
1.84      markster  540:              /* Hangup the original channel now, in cas
e we needed it */
                    541:              ast_hangup(winner);
1.24      markster  542:              continue;
1.22      markster  543:          }
1.7       markster  544:          f = ast_read(winner);
                    545:          if (f) {
                    ..........................
                    654:      }
                    655:      o = o->next;
                    656:  }

i wonder if the "continue" in line 542 shouldn't be preceded by "o = o->next;"
or better yet change the while() into a proper for loop

                    432:  for (o=outgoing; o; o = o->next) {

Comments anyone ?

	cheers
	luigi