[Asterisk-Dev] app_datetime unused ? and sayunixtime cleanup...
Kevin P. Fleming
kpfleming at digium.com
Tue Nov 15 08:46:13 MST 2005
Luigi Rizzo wrote:
> If this is the case, could we just cvs delete it ?
> Should i open a bug in mantis ?
Yes please.
> Also (post 1.2) i notice that app_sayunixtime has hardwired
> syntaxes for the various languages e.g. in sayunixtime_exec():
>
> if( !strcasecmp(chan->language, "da" ) ) {
> format = "A dBY HMS";
> } else if ( !strcasecmp(chan->language, "de" ) ) {
> format = "A dBY HMS";
> } else {
> format = "ABdY 'digits/at' IMp";
> }
>
> This seems wrong, because the language-specific rules to play dates
> times etc are already in the "say" application, and there is
> even a specific function ast_say_date() to do that...
>
> So we could just call ast_say_date() if the caller does not
> override the format, or ast_say_date_with_format() otherwise ?
Sounds reasonable.
More information about the asterisk-dev
mailing list