[Asterisk-Dev] Need help to get into the code

[Bob Goddard]

On Monday 16 May 2005 15:09, Kevin P. Fleming wrote:
> Bob Goddard wrote:
> > Then no patches should be accepted without comments, especially
> > where new functions are added. Take a look at func_callerid.c,
> > a new file that has been added without a single comment.
>
> We do not add comments for code that is self-explanatory, they are a
> waste of time and extra maintenance because they have to be kept in sync
> with the code.
>
> Tell me, what code in func_callerid.c needs to be commented?

How about it all?

Looking at callerid_read, I would assume from the name that it would
read the callerid from the channel. To get what it actually does, I
would have to read the piece of code which calls it. I cannot see
what the /cmd/ variable is supposed to be used for as it is never
accessed in that function.


B