[Asterisk-Dev] [patch] Possible fix for subscribe bug.

[Olle E. Johansson]

Steve Davies wrote:
> Hi,
> 
> A couple of days ago I posted regarding SIP 'SUBSCRIBE's failing from
> our snom190 phones here:
>     http://lists.digium.com/pipermail/asterisk-users/2005-May/106545.html
> 
> I did some more analysis, and it seems that the problem is caused
> because each of our phones REGISTERs as two or more users on the same
> server (So that the user can choose an identity for outgoing calls)
> 
> This means that when a subscribe comes in, it calls to
> check_user_full(...), which then calls find_peer(NULL,ip_address) -
> the find_peer call was of course only returning ONE of the
> registrations for that IP address.
> 
> The failure was due to an inability to authenticate the SUBSCRIBE, and
> this was happening when the phone was trying to SUBSCRIBE using
> credentials from "SIP/line1", and find_peer(...) was returning
> credentials for the correct phone, but for "SIP/line2".
> 
> I have provided 2 versions of a simple patch, one against 1.0.7 and
> once against CVS-HEAD, and would appreciate comments. I have given the
> 1.0.7 version some basic testing, and have found no obvious problems.
> 
This patch is already in the bug tracker, without many comments or
feedback from other people. The basic problem is that we are
trying to authenticate with the From: user name instead of the digest
auth username, but that's a much larger fix.

/O