[Asterisk-Dev] [Rant] [long] - code style and quality

[Mikael Magnusson]

On Fri, May 06, 2005 at 08:59:31PM -0500, Steven wrote:
> On Fri, 2005-05-06 at 15:54 -0700, Luigi Rizzo wrote:
> 
> > LIST OF COMMON STYLE BUGS
> > 
> > 1. in many cases we have blocks of this kind:
> > 
> > 	if (condition) {
> > 		bla bla bla...
> > 		... 100+ lines of code ...
> > 	} else {
> > 		ast_log(LOG_WARNING, "too bad, can't do that");
> > 		return -1;
> > 	}
> 
> I once submitted a patch to Mark to fox one specific instance of the
> above. The trouble with those patches is that the diff doesn't make it
> obvious that it is a simple change and with it being potentially several
> pages long, it is one that isn't always accepted quickly or at all. 
> 

It shouldn't be too hard to read if it's separated into two patches.
One with white-space changes (indentation for example) only and one with
the real changes. For example the mplayer project requires that for patches
that contains large amounts of white-space changes.

/Mikael Magnuson