[Asterisk-Dev] sensible buffer size management

Olle E. Johansson oej at edvina.net
Wed May 4 04:00:55 MST 2005


Luigi Rizzo wrote:
> It is always good practice to use constants instead of magic numbers
> to define the size of data structures, e.g.
> 
> 	./channels/chan_iax2.c: char context[AST_MAX_EXTENSION];
> 
> and not
> 
> 	./channels/chan_iax2.c: char context[80];
> 	./pbx/pbx_spool.c:      char context[256];
> 	./utils/astman.c:       char context[20];
> 

> If there is interest to clean up this situation at list partly,
> i am willing to do a bit of mechanical work
> and submit patches to clean up this situation. However, given that
> it is a lot of work both on the reporter and the committer side,
> I wanted to first ask ...
> 
I am in favour of this change.

/O



More information about the asterisk-dev mailing list