[Asterisk-Dev] Re: Asterisk H.323 driver

[Paul Cadach]

Hello,

Chih-Wei Huang wrote:
> Paul Cadach wrote:
[skipped]
> > Also, there was flawless H323_ExternalRTPChannel::Start() call (or missed
> > call) found some time ago. Because OpenH323 is out-of-tree and isn't maintained together with Asterisk so
inheritance of
> > H323_ExternalRTPChannel is a single possible workaround for one-line fix of OpenH323.
>
> I don't really understand what you mean.
> But I can guess what you concern.
> You are afraid Openh323 been changed in future
> so that my implementation will be broken?

I had next patch for openh323 1.12.2 (not one-line but two-line, not so much important):
diff -u --recursive --new-file openh323/src/h323neg.cxx.startup openh323/src/h323neg.cxx
--- openh323/src/h323neg.cxx.startup    Thu Jan 30 07:38:19 2003
+++ openh323/src/h323neg.cxx    Sun Nov  2 23:24:40 2003
@@ -785,8 +785,9 @@
     }
   }

-  if (!channel->Open())
-    return FALSE;
+// Don't open logical channel until it's not ACKed by remote
+//  if (!channel->Open())
+//    return FALSE;

   if (!channel->SetInitialBandwidth()) {
     PTRACE(3, "H245\tOpening channel: " << channelNumber << ", Insufficient bandwidth");

With this patch it's possible to not create inheritance from H323_ExternalRTPChannel class (as I remember - there was
about 1 year ago).


WBR,
Paul.