[Asterisk-Dev] Re: asterisk/channels chan_iax2.c, 1.188.2.13, 1.188.2.14

[Steve Kann]

Tony Mountifield wrote:

>I haven't tried it, but isn't the patch below going to result in a log
>warning for every incoming IAX packet? That could be a lot of messages!
>If that is true, perhaps there needs to be a flag so that the warning
>is only output once per connection, session or something.
>  
>

It would.  But it also means that the whole call isn't going to work, so 
it's not like it's some benign warning..




>Cheers
>Tony
>
>In article <20050318173450.3667B2FFAB3 at lists.digium.com>,
> <russell at lists.digium.com> wrote:
>  
>
>>Update of /usr/cvsroot/asterisk/channels
>>In directory mongoose.digium.com:/tmp/cvs-serv6688/channels
>>
>>Modified Files:
>>      Tag: v1-0
>>	chan_iax2.c 
>>Log Message:
>>don't explode if a box running CVS head sends trunk frames with timestamps (bug #3790)
>>
>>
>>Index: chan_iax2.c
>>===================================================================
>>RCS file: /usr/cvsroot/asterisk/channels/chan_iax2.c,v
>>retrieving revision 1.188.2.13
>>retrieving revision 1.188.2.14
>>diff -u -d -r1.188.2.13 -r1.188.2.14
>>--- chan_iax2.c	7 Feb 2005 04:05:29 -0000	1.188.2.13
>>+++ chan_iax2.c	18 Mar 2005 17:30:05 -0000	1.188.2.14
>>@@ -5063,6 +5063,10 @@
>> 		/* This is a meta header */
>> 		switch(meta->metacmd) {
>> 		case IAX_META_TRUNK:
>>+		        if (meta->cmddata != 0) {
>>+				ast_log(LOG_WARNING, "meta trunk cmd %d received, I only understand 0 (perhaps the remote side is sending trunk
>>timestamps?)\n", meta->cmddata);
>>+				return 1;
>>+		        }
>> 			if (res < sizeof(struct ast_iax2_meta_hdr) + sizeof(struct ast_iax2_meta_trunk_hdr)) {
>> 				ast_log(LOG_WARNING, "midget meta trunk packet received (%d of %d min)\n", res, (int)sizeof(struct ast_iax2_mini_hdr));
>> 				return 1;
>>
>>_______________________________________________
>>Asterisk-Cvs mailing list
>>Asterisk-Cvs at lists.digium.com
>>http://lists.digium.com/mailman/listinfo/asterisk-cvs
>>
>>    
>>
>
>
>  
>