[Asterisk-Dev] chan_sip still borked in CVS-HEAD

[Luigi Rizzo]

On Thu, Jun 23, 2005 at 03:02:41AM -0500, Brian Capouch wrote:
> I fetched the code with the strcasecmp patch.  It registers at first, 
> but repoducibly fails later on, with these errors:

partly related - as someone pointed out to the list and verified
in the SIP spec (RFC3261 sec 7.3.1) and related ones,
most SIP tokens, field and parameter names and values are
case-insensitive, yet there are still some strstr() instances
in chan_sip.c which may cause a bit of trouble:

> grep -n strstr channels/chan_sip.c
3501:                   oh = strstr(tmp, ";rport");
3598:   maddr = strstr(h, "maddr=");
5189:           expires = strstr(get_header(req, "Contact"), "expires=");
6078:           c = strstr(via, ";rport");
6155:   if (strstr(input,"privacy=full") || strstr(input,"privacy=uri"))
8296:                                   if( (tmptmp=strstr(contact, p->our_contact))) {
8303:                   tmptmp = strstr(contact, "expires=");
11311:          if ((localtmp = strstr(tmp, "sip:")) && (localtmp = strchr(localtmp, '@'))) {

these need to be fixed too.

	cheers
	luigi

> Jun 23 02:12:22 WARNING[2404]: chan_sip.c:1046 retrans_pkt: Maximum 
> retries exceeded on call 0fa37491069408951220db6e42d357d7 at 10.1.2.3 for 
> seqno 234 (Critical Request)
> Jun 23 02:12:30 NOTICE[2404]: chan_sip.c:4700 sip_reg_timeout:    -- 
> Registration for '14082152799 at natrelay.deltathree.com' timed out, trying 
> again (Attempt #133)
> 
> CLI> sip show registry
> Host                            Username       Refresh State
> natrelay.deltathree.com:5060    14082152799        105 Failed
> 
> 
> I will dig some tomorrow, but at this point Asterisk no longer seems to 
> retry the registration.  That didn't used to happen with the code from 
> ~10 days ago. . . .
> 
> B.
> _______________________________________________
> Asterisk-Dev mailing list
> Asterisk-Dev at lists.digium.com
> http://lists.digium.com/mailman/listinfo/asterisk-dev
> To UNSUBSCRIBE or update options visit:
>    http://lists.digium.com/mailman/listinfo/asterisk-dev