[Asterisk-Dev] DIAL_PRESERVE_CALLERID logic (Dial() option 'o')

[Thomas Andrews]

On Wed, Jul 13, 2005 at 12:17:14PM -0500, Tilghman Lesher wrote:

> > Thomas Andrews wrote:
> > > I can't think of any situation where you would *not* want the 'o'
> > > flag.
> >
> > This is a confusing situation ...
> >
> > It is important to note that the callerid that is being changed is
> > the callerid of the *called* channel, not the *calling* channel.  The
> > issue is that there is not a reliable way to know what the callerid
> > of the *called* channel should be, aside from a 'hint' in the
> > dialplan.
> >
> > Otherwise, without this new behavior, the *called* channel's callerid
> > will be the same as the callerid of the *calling* channel.  This is
> > obviously incorrect behavior.
> >
> > The behavior we have now is surely more accurate than it was before.
> 
> Wouldn't this be a tiny bit less confusing if we referred to it as the
> CALLEDID and not CALLERID?  Might we make that one letter
> change to the variable name?

No, it's the same variable used in a different context. In the one case
it's meaningful, in the other it's confusing. You could have two
variables, I don't know ...