[Asterisk-Dev] Crappy New Year - AGI is b0rked

Paul Liew pliew at atp.org.au
Wed Dec 31 18:01:57 MST 2003


>
> I remember having problems with AGI after I applied PHM's patch which
since has been comitted to CVS.  I'm not sure what it was supposted to fix,
but it gave me some problems.
>
> This will take it back out:
>
> --- app_agi.c.prev      Thu Dec 25 19:11:35 2003
> +++ app_agi.c   Thu Dec 25 19:14:27 2003
> @@ -167,10 +167,6 @@
>         /* close what we're not using in the parent */
>         close(toast[1]);
>         close(fromast[0]);
> -
> -        // [PHM 12/18/03]
> -        close(audio[0]);
> -
>         *opid = pid;
>         return 0;
>
> Kevin

This definitely causes agi scripts to break - its ok for eagi, because the
audio pipe is open, in agi its not, so closing a non-existing fd will crash.
So uncomment that "close" bit and it should be ok. Its bug 698 but its
closed, can someone at digium re-open, and patch it with a check for the fd
before closing it? Thanks.

Paul




More information about the asterisk-dev mailing list