<p> Attention is currently required from: N A, George Joseph, Eric Dantie. </p>
<p>Patch set 16:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/19921">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">Patchset:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19921?tab=comments">Patch Set #16:</a> </p><p style="white-space: pre-wrap; word-wrap: break-word;">So even though I know what is going on here I do think the commit message and CHANGES file are confusing. Other modules have the concept of "more than one database" but those are referring to logical database connections defined within Asterisk itself, e.g.:</p><p style="white-space: pre-wrap; word-wrap: break-word;">```<br>[server1]<br>host = foo<br>schema = blah</p><p style="white-space: pre-wrap; word-wrap: break-word;">[server2]<br>host = baz<br>schema = meh<br>```</p><p style="white-space: pre-wrap; word-wrap: break-word;">So my suggestion is that the commit summary (the first line) just indicate that you've added support for PostgreSQL Connection URIs. Then in the body of the commit message and the CHANGES file, you can explain how that using a Connection URI allows you to configure multiple hosts, connection properties, etc.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/19921">change 19921</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/19921"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I9ca8705c96acdd4a10989d981a5c2583a160aa44 </div>
<div style="display:none"> Gerrit-Change-Number: 19921 </div>
<div style="display:none"> Gerrit-PatchSet: 16 </div>
<div style="display:none"> Gerrit-Owner: Eric Dantie <edantie@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Eric Dantie <edantie@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: N A <asterisk@phreaknet.org> </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean@seanbright.com> </div>
<div style="display:none"> Gerrit-Attention: N A <asterisk@phreaknet.org> </div>
<div style="display:none"> Gerrit-Attention: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Attention: Eric Dantie <edantie@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 03 Apr 2023 14:10:29 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>