<p> Attention is currently required from: Sean Bright, Nathan Bruning. </p>
<p>Patch set 3:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/19797">View Change</a></p><p>5 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">Patchset:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19797?tab=comments">Patch Set #1:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Hi Sean, […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Have you tried generating a video file yourself using Record() or one of the video-supporting applications? It's been a while since I've done that, but I seem to recall that you can generate your own compatible h264 files that way.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File main/file.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19797/comment/9c72fd32_8330ae03">Patch Set #3, Line 546:</a> <code style="font-family:monospace,monospace"> if ( (bfile = fopen(fn, "r")) == NULL) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Remove the extra space between the parentheses</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19797/comment/3fccd721_c4ed2e5e">Patch Set #3, Line 564:</a> <code style="font-family:monospace,monospace"> if (ast_channel_stream(chan))</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">The "optional" braces are always required per the coding guidelines: https://wiki.asterisk.org/wiki/display/AST/Coding+Guidelines#CodingGuidelines-Nonestedstatementswithoutbraces</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19797/comment/aa80bb00_34210372">Patch Set #3, Line 568:</a> <code style="font-family:monospace,monospace"> if (ast_channel_vstream(chan))</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Same here</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19797/comment/80873168_e49ffc98">Patch Set #3, Line 587:</a> <code style="font-family:monospace,monospace"> {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Move the opening brace to the previous line, just like a for loop.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/19797">change 19797</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/19797"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: If6b5f4af9cbdf39009252594eb987b07bfb493a4 </div>
<div style="display:none"> Gerrit-Change-Number: 19797 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Nathan Bruning <nathan@iperity.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: N A <asterisk@phreaknet.org> </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean@seanbright.com> </div>
<div style="display:none"> Gerrit-Attention: Sean Bright <sean@seanbright.com> </div>
<div style="display:none"> Gerrit-Attention: Nathan Bruning <nathan@iperity.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Sat, 01 Apr 2023 22:46:27 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Comment-In-Reply-To: Sean Bright <sean@seanbright.com> </div>
<div style="display:none"> Comment-In-Reply-To: Nathan Bruning <nathan@iperity.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>