<p> Attention is currently required from: Martin McCarthy. </p>
<p>Patch set 3:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/19974">View Change</a></p><p>9 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">Patchset:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19974?tab=comments">Patch Set #3:</a> </p><p style="white-space: pre-wrap; word-wrap: break-word;">There are still some packages being added that shouldn't be.</p><p style="white-space: pre-wrap; word-wrap: break-word;">It's very obvious when you look at the diff:</p><p style="white-space: pre-wrap; word-wrap: break-word;">https://gerrit.asterisk.org/c/asterisk/+/19974/3/contrib/scripts/install_prereq</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File contrib/scripts/install_prereq:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19974/comment/be837086_81beb7a3">Patch Set #3, Line 28:</a> <code style="font-family:monospace,monospace">PACKAGES_DEBIAN="$PACKAGES_DEBIAN libmysqlclient-dev libbluetooth-dev libradcli-dev freetds-dev libosptk-dev libjack-jackd2-dev bash libcap-dev"</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Remove `libosptk-dev`</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19974/comment/6c969286_5bc66209">Patch Set #3, Line 42:</a> <code style="font-family:monospace,monospace">PACKAGES_RH="$PACKAGES_RH speex-devel speexdsp-devel libogg-devel libvorbis-devel alsa-lib-devel portaudio-devel libcurl-devel xmlstarlet bison flex"</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Remove `alsa-lib-devel`</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19974/comment/3f7fc23b_a2c13e2f">Patch Set #3, Line 58:</a> <code style="font-family:monospace,monospace">PACKAGES_SUSE="$PACKAGES_SUSE speex-devel speexdsp-devel libogg-devel libvorbis-devel alsa-devel portaudio-devel libcurl-devel xmlstarlet bison flex"</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Remove `alsa-devel`</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19974/comment/760f6e20_4426c45a">Patch Set #3, Line 74:</a> <code style="font-family:monospace,monospace">PACKAGES_ARCH="$PACKAGES_ARCH speex speexdsp libogg libvorbis alsa-lib portaudio curl xmlstarlet bison flex"</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Remove `alsa-lib`</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19974/comment/e2019861_e84c2628">Patch Set #3, Line 90:</a> <code style="font-family:monospace,monospace">PACKAGES_GENTOO="$PACKAGES_GENTOO media-libs/speex media-libs/speexdsp media-libs/libogg media-libs/libvorbis media-libs/alsa-lib media-libs/portaudio net-misc/curl app-text/xmlstarlet sys-devel/bison sys-devel/flex"</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Remove `media-libs/alsa-libs`</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19974/comment/ca2db3bb_0ef87054">Patch Set #3, Line 106:</a> <code style="font-family:monospace,monospace">PACKAGES_NBSD="$PACKAGES_NBSD speex speexdsp libogg libvorbis alsa-lib portaudio-devel curl bison flex"</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Remove `alsa-lib`</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19974/comment/0ad902bd_0145b318">Patch Set #3, Line 138:</a> <code style="font-family:monospace,monospace">PACKAGES_FBSD="$PACKAGES_FBSD speex speexdsp libogg libvorbis alsa-lib portaudio curl xmlstarlet bison flex"</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Remove `alsa-lib`</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19974/comment/8d9cde46_361214c2">Patch Set #3, Line 154:</a> <code style="font-family:monospace,monospace">PACKAGES_DBSD="$PACKAGES_DBSD speex speexdsp libogg libvorbis alsa-lib portaudio curl xmlstarlet bison flex"</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Remove `alsa-lib`</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/19974">change 19974</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/19974"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I9c140c7f12ca7dafe65c317f2a26122cf2c72556 </div>
<div style="display:none"> Gerrit-Change-Number: 19974 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Martin McCarthy <martin.c.mccarthy@outlook.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean@seanbright.com> </div>
<div style="display:none"> Gerrit-Attention: Martin McCarthy <martin.c.mccarthy@outlook.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 16 Mar 2023 22:28:09 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>