<p> Attention is currently required from: Sean Bright, N A, Joshua Colp. </p>
<p>Patch set 14:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #d4ffd4; color: #000000;">Code-Review +1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/19921">View Change</a></p><p>11 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">Commit Message:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19921/comment/3fbe10ae_16929b87">Patch Set #3, Line 7:</a> <code style="font-family:monospace,monospace">Add parameter dburl to res_config_pgsql to permit adding more than one database and parameters</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Still not quite there, something like this would be better: […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">Commit Message:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19921/comment/d233c24e_25883a2b">Patch Set #10, Line 7:</a> <code style="font-family:monospace,monospace">res/res_config_pgsql permit more than one database.</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Comma needed after res_config_pgsql. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">Patchset:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19921?tab=comments">Patch Set #14:</a> </p><p style="white-space: pre-wrap; word-wrap: break-word;">Thanks</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File configs/samples/res_pgsql.conf.sample:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19921/comment/180a5835_7e43457f">Patch Set #3, Line 10:</a> <code style="font-family:monospace,monospace">dburl=postgresql://127.0.0.1:5432/asterisk?target_session_attrs=any&application_name=asterisk</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Is this a valid configuration? Both dburl and dbhost are now specified in this sample configuration</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">It's the same as the default parameters with the error that target_session_attrs must be changed.</p><p style="white-space: pre-wrap; word-wrap: break-word;">target_session_attrs=read-write</p><p style="white-space: pre-wrap; word-wrap: break-word;">I've kept the others values for compatibility with older versions, but should it keep it that way or just using dburi?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File configs/samples/res_pgsql.conf.sample:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19921/comment/0ba7bcf6_a44130f4">Patch Set #10, Line 8:</a> <code style="font-family:monospace,monospace">;</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">It should be specified here how the configuration works when dburi is specified and how it interacts […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Ack</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File configs/samples/res_pgsql.conf.sample:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19921/comment/39e17f66_37bf4065">Patch Set #11, Line 9:</a> <code style="font-family:monospace,monospace">; - With the other parameters dbhost, ...</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">It's a little unclear where you're going with the ellipses here</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File res/res_config_pgsql.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19921/comment/e29acb82_ec73aea3">Patch Set #3, Line 58:</a> <code style="font-family:monospace,monospace">#define MAX_URL_OPTION_SIZE 256</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Where does 256 come from?</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">It's a arbitrary value. But it should be long enough for example the dburl I use is: <br>dburl=postgresql://asterisk:asterisk@lpa-pg-tfe.contactel.es:5432,tfe-pg-tfe.contactel.es:5432,mtp-pg-tfe.contactel.es:5432/pruebas?target_session_attrs=read-write</p><p style="white-space: pre-wrap; word-wrap: break-word;">I don't known if there is a way to get the length dynamically</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19921/comment/9ee79ad6_479d12b7">Patch Set #3, Line 1584:</a> <code style="font-family:monospace,monospace"> ast_debug(1, "pgsqlConn=%p\n", pgsqlConn);</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">This should be removed, it doesn't really help.</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">You are right</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File res/res_config_pgsql.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19921/comment/76d80d66_2be1c535">Patch Set #7, Line 1464:</a> <code style="font-family:monospace,monospace"> ast_log(LOG_DEBUG,</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Don't ast_log to LOG_DEBUG directly. Use the ast_debug macro.</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19921/comment/8b7efa03_690b1fcf">Patch Set #7, Line 1468:</a> <code style="font-family:monospace,monospace"></code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Extra line is not needed here</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File res_config_pgsql.txt:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19921/comment/2c85f983_5b71c5f9">Patch Set #10, Line 1:</a> <code style="font-family:monospace,monospace">Subject: Add support for multiples databases</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">The subject for CHANGES entries should be the name of the module. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/19921">change 19921</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/19921"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I9ca8705c96acdd4a10989d981a5c2583a160aa44 </div>
<div style="display:none"> Gerrit-Change-Number: 19921 </div>
<div style="display:none"> Gerrit-PatchSet: 14 </div>
<div style="display:none"> Gerrit-Owner: Eric Dantie <edantie@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Eric Dantie <edantie@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: N A <asterisk@phreaknet.org> </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean@seanbright.com> </div>
<div style="display:none"> Gerrit-Attention: Sean Bright <sean@seanbright.com> </div>
<div style="display:none"> Gerrit-Attention: N A <asterisk@phreaknet.org> </div>
<div style="display:none"> Gerrit-Attention: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 16 Mar 2023 11:42:50 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Comment-In-Reply-To: N A <asterisk@phreaknet.org> </div>
<div style="display:none"> Comment-In-Reply-To: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>