<p> Attention is currently required from: Sean Bright. </p>
<p><a href="https://gerrit.asterisk.org/c/asterisk/+/19797">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">Patchset:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19797?tab=comments">Patch Set #1:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Some thoughts: […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Hi Sean,</p><p style="white-space: pre-wrap; word-wrap: break-word;">Changing the directory layout could be an option, but potentially would break customer setups - for example, we have some pruning scripts to avoid the cache to grow indefinitely.</p><p style="white-space: pre-wrap; word-wrap: break-word;">I agree the fix is better suited in `bucket_file_update_path`, so i can submit something like</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">```<br>int c = 0;<br>while(file_exists_with_any_extension("%s%i.%s", filename, c, ext)) {<br>   c++<br>}<br>rename(...)<br>```</pre><p style="white-space: pre-wrap; word-wrap: break-word;">so just append a counter to the result of `ast_bucket_file_temporary_create` until we're sure it's unique?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/19797">change 19797</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/19797"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: If6b5f4af9cbdf39009252594eb987b07bfb493a4 </div>
<div style="display:none"> Gerrit-Change-Number: 19797 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Nathan Bruning <nathan@iperity.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: N A <asterisk@phreaknet.org> </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean@seanbright.com> </div>
<div style="display:none"> Gerrit-Attention: Sean Bright <sean@seanbright.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 01 Feb 2023 12:43:19 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: Sean Bright <sean@seanbright.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>