<p> Attention is currently required from: Michael Bradeen. </p>
<p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/19794">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">File apps/app_directory.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19794/comment/335dd464_e1ea56e1">Patch Set #2, Line 485:</a> <code style="font-family:monospace,monospace"> cfg = ast_config_load(S_OR(filename, VOICEMAIL_CONFIG), config_flags);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Instead of doing S_OR here just pass filename. The caller should always specify the file to get the config from.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19794/comment/38ba66bf_6c5a5451">Patch Set #2, Line 492:</a> <code style="font-family:monospace,monospace"> ast_log(LOG_ERROR, "Config file %s is in an invalid format. Aborting.\n", VOICEMAIL_CONFIG);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Need to replace VOICEMAIL_CONFIG with filename.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19794/comment/7a08d886_2988c21f">Patch Set #2, Line 877:</a> <code style="font-family:monospace,monospace"> cfg = realtime_directory(args.vmcontext, S_OR(opts[OPT_ARG_FILENAME], ""));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Instead of passing an empty string you should pass VOICEMAIL_CONFIG. This way you don't need to do another S_OR in realtime_directory().</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/19794">change 19794</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/19794"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 18 </div>
<div style="display:none"> Gerrit-Change-Id: Id58ccb1344ad1e563fa10db12f172fbd104a9d13 </div>
<div style="display:none"> Gerrit-Change-Number: 19794 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Michael Bradeen <mbradeen@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: N A <asterisk@phreaknet.org> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Attention: Michael Bradeen <mbradeen@sangoma.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 26 Jan 2023 19:29:19 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>