<p>George Joseph <strong>submitted</strong> this change.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/19830">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span></span><br></pre><div style="white-space:pre-wrap">Approvals:
Joshua Colp: Looks good to me, but someone else must approve
George Joseph: Looks good to me, approved; Approved for Submit
N A: Looks good to me, but someone else must approve
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">app_playback.c: Fix PLAYBACKSTATUS regression.<br><br>In Asterisk 11, if a channel was redirected away during Playback(),<br>the PLAYBACKSTATUS variable would be set to SUCCESS. In Asterisk 12<br>(specifically commit 7d9871b3940fa50e85039aef6a8fb9870a7615b9) that<br>behavior was inadvertently changed and the same operation would result<br>in the PLAYBACKSTATUS variable being set to FAILED. The Asterisk 11<br>behavior has been restored.<br><br>Partial fix for ASTERISK~25661.<br><br>Change-Id: I53f54e56b59b61c99403a481b6cb8d88b5a559ff<br>---<br>M apps/app_playback.c<br>A doc/UPGRADE-staging/app_playback_playbackstatus.txt<br>2 files changed, 27 insertions(+), 2 deletions(-)<br><br></pre>
<pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/apps/app_playback.c b/apps/app_playback.c</span><br><span>index 56c2a86..afa959b 100644</span><br><span>--- a/apps/app_playback.c</span><br><span>+++ b/apps/app_playback.c</span><br><span>@@ -507,8 +507,7 @@</span><br><span> if (!res) {</span><br><span> res = ast_waitstream(chan, "");</span><br><span> ast_stopstream(chan);</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- if (res) {</span><br><span style="color: hsl(120, 100%, 40%);">+ } else {</span><br><span> if (!ast_check_hangup(chan)) {</span><br><span> ast_log(LOG_WARNING, "Playback failed on %s for %s\n", ast_channel_name(chan), (char *)data);</span><br><span> }</span><br><span>diff --git a/doc/UPGRADE-staging/app_playback_playbackstatus.txt b/doc/UPGRADE-staging/app_playback_playbackstatus.txt</span><br><span>new file mode 100644</span><br><span>index 0000000..49302b7</span><br><span>--- /dev/null</span><br><span>+++ b/doc/UPGRADE-staging/app_playback_playbackstatus.txt</span><br><span>@@ -0,0 +1,8 @@</span><br><span style="color: hsl(120, 100%, 40%);">+Subject: app_playback</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+In Asterisk 11, if a channel was redirected away during Playback(),</span><br><span style="color: hsl(120, 100%, 40%);">+the PLAYBACKSTATUS variable would be set to SUCCESS. In Asterisk 12</span><br><span style="color: hsl(120, 100%, 40%);">+(specifically commit 7d9871b3940fa50e85039aef6a8fb9870a7615b9) that</span><br><span style="color: hsl(120, 100%, 40%);">+behavior was inadvertently changed and the same operation would result</span><br><span style="color: hsl(120, 100%, 40%);">+in the PLAYBACKSTATUS variable being set to FAILED. The Asterisk 11</span><br><span style="color: hsl(120, 100%, 40%);">+behavior has been restored.</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/19830">change 19830</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/19830"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 18 </div>
<div style="display:none"> Gerrit-Change-Id: I53f54e56b59b61c99403a481b6cb8d88b5a559ff </div>
<div style="display:none"> Gerrit-Change-Number: 19830 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Sean Bright <sean@seanbright.com> </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: N A <asterisk@phreaknet.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>