<p> Attention is currently required from: Michael Bradeen. </p>
<p>Patch set 5:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/19611">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">Patchset:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19611?tab=comments">Patch Set #2:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Sorry, a couple more stragglers: […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">This chan_sip stuff should also be removed:</p><p style="white-space: pre-wrap; word-wrap: break-word;">contrib/scripts/autosupport:      "sip show peers" "sip show registry" "sip show channels" "sip show subscriptions" "sip show settings"</p><p style="white-space: pre-wrap; word-wrap: break-word;">Additionally, these contrib scripts are obsolete:</p><p style="white-space: pre-wrap; word-wrap: break-word;">contrib/scripts/retrieve_sip_conf_from_mysql.pl:# Retrieves the sip user/peer entries from the database<br>contrib/scripts/retrieve_sip_conf_from_mysql.pl:#CREATE TABLE sip (id INT(11) DEFAULT -1 NOT NULL,keyword VARCHAR(20) NOT NULL,data VARCHAR(50) NOT NULL, flags INT(1) DEFAULT 0 NOT NULL,PRIMARY KEY (id,keyword));<br>contrib/scripts/retrieve_sip_conf_from_mysql.pl:$table_name = "sip";<br>contrib/scripts/retrieve_sip_conf_from_mysql.pl:$sip_conf = "/etc/asterisk/sip_additional.conf";<br>contrib/scripts/retrieve_sip_conf_from_mysql.pl:$database = "sip";<br>contrib/scripts/retrieve_sip_conf_from_mysql.pl:open EXTEN, ">$sip_conf" || die "Cannot create/overwrite extensions file: $sip_conf\n";<br>contrib/scripts/retrieve_sip_conf_from_mysql.pl:  print "No sip accounts defined in $table_name\n";</p><p style="white-space: pre-wrap; word-wrap: break-word;">contrib/scripts/ast_logescalator:               \$astlogdir/sip_history.\$UNIQUEID.<br>contrib/scripts/ast_logescalator:       \$astlogdir/sip_history.\$uniqueid<br>contrib/scripts/ast_logescalator:[SIP,on]="sip set debug on" [SIP,off]="sip set debug off"<br>contrib/scripts/ast_logescalator:       --sip-history=*)<br>contrib/scripts/ast_logescalator:               asterisk -rx "sip set debug off"<br>contrib/scripts/ast_logescalator:               asterisk -rx "sip set history off"<br>contrib/scripts/ast_logescalator:       SIP_HISTORY_LOG="$LOG_DIR/sip_history.${UNIQUEID}"<br>contrib/scripts/ast_logescalator:       [sip_debug](!)<br>contrib/scripts/ast_logescalator:       sip set debug on = yes<br>contrib/scripts/ast_logescalator:       [sip_history](!)<br>contrib/scripts/ast_logescalator:       sip set history on = yes<br>contrib/scripts/ast_logescalator:       SIP_HISTORY_LOG=$(sed -n -r -e "s@logger add channel ($LOG_DIR/sip_history\..+)\s+SIP.*@\1@p" "$CLI_CONF")</p><p style="white-space: pre-wrap; word-wrap: break-word;">There also seem to be a bunch of alembic scripts left. I'm not sure if those have to stay or not, maybe somebody else knows, but just wanted to point these out:</p><p style="white-space: pre-wrap; word-wrap: break-word;">contrib/ast-db-manage/config/versions/4da0c5f79a9c_create_tables.py:        'sippeers',<br>contrib/ast-db-manage/config/versions/4da0c5f79a9c_create_tables.py:                  name='sip_transport_values')),<br>contrib/ast-db-manage/config/versions/4da0c5f79a9c_create_tables.py:                  name='sip_dtmfmode_values')),<br>contrib/ast-db-manage/config/versions/4da0c5f79a9c_create_tables.py:                  name='sip_directmedia_values')),<br>contrib/ast-db-manage/config/versions/4da0c5f79a9c_create_tables.py:                  name='sip_progressinband_values')),<br>contrib/ast-db-manage/config/versions/4da0c5f79a9c_create_tables.py:                  name='sip_session_timers_values')),<br>contrib/ast-db-manage/config/versions/4da0c5f79a9c_create_tables.py:                  name='sip_session_refresher_values')),<br>contrib/ast-db-manage/config/versions/4da0c5f79a9c_create_tables.py:                  name='sip_callingpres_values')),<br>contrib/ast-db-manage/config/versions/4da0c5f79a9c_create_tables.py:    op.create_index('sippeers_name', 'sippeers', ['name'])<br>contrib/ast-db-manage/config/versions/4da0c5f79a9c_create_tables.py:    op.create_index('sippeers_name_host', 'sippeers', ['name', 'host'])<br>contrib/ast-db-manage/config/versions/4da0c5f79a9c_create_tables.py:    op.create_index('sippeers_ipaddr_port', 'sippeers', ['ipaddr', 'port'])<br>contrib/ast-db-manage/config/versions/4da0c5f79a9c_create_tables.py:    op.create_index('sippeers_host_port', 'sippeers', ['host', 'port'])<br>contrib/ast-db-manage/config/versions/4da0c5f79a9c_create_tables.py:    op.drop_table('sippeers')<br>contrib/ast-db-manage/config/versions/4da0c5f79a9c_create_tables.py:             'sip_transport_values','sip_dtmfmode_values','sip_directmedia_values',<br>contrib/ast-db-manage/config/versions/4da0c5f79a9c_create_tables.py:             'sip_progressinband_values','sip_session_timers_values','sip_session_refresher_values',<br>contrib/ast-db-manage/config/versions/4da0c5f79a9c_create_tables.py:             'sip_callingpres_values','iax_requirecalltoken_values','iax_encryption_values',<br>contrib/ast-db-manage/config/versions/10aedae86a32_add_outgoing_enum_va.py:"""Add Outgoing enum value to sippeers directmedia<br>contrib/ast-db-manage/config/versions/10aedae86a32_add_outgoing_enum_va.py:old_type = sa.Enum(*OLD_ENUM, name='sip_directmedia_values')<br>contrib/ast-db-manage/config/versions/10aedae86a32_add_outgoing_enum_va.py:new_type = sa.Enum(*NEW_ENUM, name='sip_directmedia_values_v2')<br>contrib/ast-db-manage/config/versions/10aedae86a32_add_outgoing_enum_va.py:tcr = sa.sql.table('sippeers', sa.Column('directmedia', new_type,<br>contrib/ast-db-manage/config/versions/10aedae86a32_add_outgoing_enum_va.py:        op.alter_column('sippeers', 'directmedia',<br>contrib/ast-db-manage/config/versions/10aedae86a32_add_outgoing_enum_va.py:                    name="sip_directmedia_values_v2")<br>contrib/ast-db-manage/config/versions/10aedae86a32_add_outgoing_enum_va.py:        op.execute('ALTER TABLE sippeers ALTER COLUMN directmedia TYPE'<br>contrib/ast-db-manage/config/versions/10aedae86a32_add_outgoing_enum_va.py:                   ' sip_directmedia_values_v2 USING'<br>contrib/ast-db-manage/config/versions/10aedae86a32_add_outgoing_enum_va.py:                   ' directmedia::text::sip_directmedia_values_v2')<br>contrib/ast-db-manage/config/versions/10aedae86a32_add_outgoing_enum_va.py:        ENUM(name="sip_directmedia_values").drop(op.get_bind(), checkfirst=False)<br>contrib/ast-db-manage/config/versions/10aedae86a32_add_outgoing_enum_va.py:        op.alter_column('sippeers', 'directmedia',<br>contrib/ast-db-manage/config/versions/10aedae86a32_add_outgoing_enum_va.py:                    name="sip_directmedia_values")<br>contrib/ast-db-manage/config/versions/10aedae86a32_add_outgoing_enum_va.py:        op.execute('ALTER TABLE sippeers ALTER COLUMN directmedia TYPE'<br>contrib/ast-db-manage/config/versions/10aedae86a32_add_outgoing_enum_va.py:                   ' sip_directmedia_values USING'<br>contrib/ast-db-manage/config/versions/10aedae86a32_add_outgoing_enum_va.py:                   ' directmedia::text::sip_directmedia_values')<br>contrib/ast-db-manage/config/versions/10aedae86a32_add_outgoing_enum_va.py:        ENUM(name="sip_directmedia_values_v2").drop(op.get_bind(),</p><p style="white-space: pre-wrap; word-wrap: break-word;">contrib/ast-db-manage/config/versions/339a3bdf53fc_expand_accountcode_to_80.py:    with op.batch_alter_table('sippeers') as batch_op:<br>contrib/ast-db-manage/config/versions/339a3bdf53fc_expand_accountcode_to_80.py:    with op.batch_alter_table('sippeers') as batch_op:<br>contrib/ast-db-manage/config/versions/1758e8bbf6b_increase_useragent_column_size.py:    op.alter_column('sippeers', 'useragent', type_=sa.String(255))<br>contrib/ast-db-manage/config/versions/1758e8bbf6b_increase_useragent_column_size.py:    op.alter_column('sippeers', 'useragent', type_=sa.String(20))</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/19611">change 19611</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/19611"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic700168c80b68879d9cee8bb07afe2712fb17996 </div>
<div style="display:none"> Gerrit-Change-Number: 19611 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: Michael Bradeen <mbradeen@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: N A <asterisk@phreaknet.org> </div>
<div style="display:none"> Gerrit-Attention: Michael Bradeen <mbradeen@sangoma.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 22 Dec 2022 14:15:13 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Comment-In-Reply-To: N A <asterisk@phreaknet.org> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>