<p> Attention is currently required from: Stanislav Abramenkov, Niklas Larsson. </p>
<p>Patch set 3:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/19741">View Change</a></p><p>5 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">Commit Message:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19741/comment/a31122c8_a4e45b93">Patch Set #3, Line 9:</a> <code style="font-family:monospace,monospace">When the Asterisk is restared it does not preserve paused reason for</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">restarted</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19741/comment/dfe6ff50_6159f597">Patch Set #3, Line 11:</a> <code style="font-family:monospace,monospace">https://gerrit.asterisk.org/c/asterisk/+/2131/</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Reference the issue number like so: ASTERISK_25732</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File apps/app_queue.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19741/comment/407cab09_f1424da8">Patch Set #3, Line 3657:</a> <code style="font-family:monospace,monospace">                 ast_copy_string(m->reason_paused, (reason_paused ? reason_paused : "\0"), sizeof(m->reason_paused));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Use S_OR(reason_paused, "")</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19741/comment/d228fc57_75de3ec7">Patch Set #3, Line 3672:</a> <code style="font-family:monospace,monospace">                   if (!ast_strlen_zero(reason_paused)){</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Missing space between ) and {</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19741/comment/a158d705_2842c2ab">Patch Set #3, Line 7753:</a> <code style="font-family:monospace,monospace">          if (strcmp(mem->reason_paused, reason ? reason : "\0")){</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Same here, use S_OR</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/19741">change 19741</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/19741"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 18 </div>
<div style="display:none"> Gerrit-Change-Id: Ica08baa5cab6b18105b5d719a183f9fd582fcf09 </div>
<div style="display:none"> Gerrit-Change-Number: 19741 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Niklas Larsson <niklas@tese.se> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: N A <asterisk@phreaknet.org> </div>
<div style="display:none"> Gerrit-Reviewer: Stanislav Abramenkov <stas.abramenkov@gmail.com> </div>
<div style="display:none"> Gerrit-Attention: Stanislav Abramenkov <stas.abramenkov@gmail.com> </div>
<div style="display:none"> Gerrit-Attention: Niklas Larsson <niklas@tese.se> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 21 Dec 2022 14:02:30 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>