<p> Attention is currently required from: Michael Bradeen. </p>
<p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/19605">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">Patchset:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19605?tab=comments">Patch Set #2:</a> </p><p style="white-space: pre-wrap; word-wrap: break-word;">This is going to be an invalid documentation reference if not removed:</p><p style="white-space: pre-wrap; word-wrap: break-word;">main/features_config.c:                                         to be monitored by the <literal>Monitor</literal> application. The</p><p style="white-space: pre-wrap; word-wrap: break-word;">Also:<br>bridges/bridge_builtin_features.c:              var_monitor = "TOUCH_MIXMONITOR";<br>bridges/bridge_builtin_features.c:              var_monitor = "TOUCH_MONITOR";</p><p style="white-space: pre-wrap; word-wrap: break-word;"><br>TOUCH_MONITOR is for Monitor so don't think that's needed anymore?</p><p style="white-space: pre-wrap; word-wrap: break-word;"><br>configs/samples/queues.conf.sample:;    By setting monitor-type = MixMonitor, when specifying monitor-format<br>configs/samples/queues.conf.sample:; monitor-type = MixMonitor</p><p style="white-space: pre-wrap; word-wrap: break-word;"><br>This should be updated, since only MixMonitor is valid now. The UPGRADE file should also mention this.</p><p style="white-space: pre-wrap; word-wrap: break-word;"><br>These should be removed:<br>configs/samples/features.conf.sample:;pauseMonitor   => #1,self/callee,Pausemonitor     ;Allow the callee to pause monitoring<br>configs/samples/features.conf.sample:;unpauseMonitor => #3,self/callee,UnPauseMonitor   ;Allow the callee to unpause monitoring</p><p style="white-space: pre-wrap; word-wrap: break-word;"><br>Also, could the ast_channel_monitor/ast_channel_monitor_set APIs be deprecated or removed in the future? It seems like only MeetMe is using them now.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/19605">change 19605</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/19605"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I0462caefb4f9544e2e2baa23c498858310b52d50 </div>
<div style="display:none"> Gerrit-Change-Number: 19605 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Michael Bradeen <mbradeen@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: N A <asterisk@phreaknet.org> </div>
<div style="display:none"> Gerrit-Attention: Michael Bradeen <mbradeen@sangoma.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 13 Dec 2022 19:27:50 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>