<p> Attention is currently required from: N A, Holger Hans Peter Freyther. </p>
<p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/19658">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">File res/res_http_media_cache.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19658/comment/902b5bcf_efc00893">Patch Set #1, Line 52:</a> <code style="font-family:monospace,monospace"> </configObject></code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">I am happy to squash them. I split them up to make it easier for review. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I think they should be squashed.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File res/res_http_media_cache.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19658/comment/4ce1c80c_2cd64d88">Patch Set #2, Line 49:</a> <code style="font-family:monospace,monospace"> <configOption name="maxrdirects" default="8"></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">misrdirects instead of misredirects</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19658/comment/33adea1e_7c89d5bc">Patch Set #2, Line 580:</a> <code style="font-family:monospace,monospace"> cfg = ast_config_load("res_http_media_cache.conf", config_flags);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This is the old style of configuration files. It is highly preferred that ACO be used, which would have caught the XML documentation error, and also would allow reload support and enforcement of values - along with defaults. An example exists in apps/app_skel.c for it.</p><p style="white-space: pre-wrap; word-wrap: break-word;">res/res_statsd.c also uses it, and has an example of using defaults.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/19658">change 19658</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/19658"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 20 </div>
<div style="display:none"> Gerrit-Change-Id: I2eb02ef44190e026716720419bcbdbcc8125777b </div>
<div style="display:none"> Gerrit-Change-Number: 19658 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Holger Hans Peter Freyther <automatic@freyther.de> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: N A <asterisk@phreaknet.org> </div>
<div style="display:none"> Gerrit-Attention: N A <asterisk@phreaknet.org> </div>
<div style="display:none"> Gerrit-Attention: Holger Hans Peter Freyther <automatic@freyther.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 12 Dec 2022 14:29:59 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Comment-In-Reply-To: N A <asterisk@phreaknet.org> </div>
<div style="display:none"> Comment-In-Reply-To: Holger Hans Peter Freyther <automatic@freyther.de> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>