<p> Attention is currently required from: Holger Hans Peter Freyther. </p>
<p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/19658">View Change</a></p><p>9 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">Commit Message:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19658/comment/3ecdfde8_cc00b946">Patch Set #1, Line 10:</a> <code style="font-family:monospace,monospace">but don't make it mandatory yet.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">So it will be mandatory in the future?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">Patchset:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19658?tab=comments">Patch Set #1:</a> </p><p style="white-space: pre-wrap; word-wrap: break-word;">This also needs a CHANGES entry</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File res/res_http_media_cache.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19658/comment/fefeff50_81243934">Patch Set #1, Line 40:</a> <code style="font-family:monospace,monospace"> <configOption name="timeout_seconds"></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">You should specify the default as well, e.g. name="timeout_secs" default="180".</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19658/comment/be25e3ff_1855423d">Patch Set #1, Line 52:</a> <code style="font-family:monospace,monospace"> </configObject></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">You submitted 3 other reviews for this config, why are they not all part of the same commit?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19658/comment/6ab743af_77b8d735">Patch Set #1, Line 70:</a> <code style="font-family:monospace,monospace">static int cache_curl_timeout = 180;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">It would be nice if these were documented briefly (just a /*! \brief desc */ is fine)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19658/comment/ae4113bb_c24fd103">Patch Set #1, Line 360:</a> <code style="font-family:monospace,monospace"> curl_easy_setopt(curl, CURLOPT_USERAGENT, cache_curl_useragent != NULL ? cache_curl_useragent : AST_CURL_USER_AGENT);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">You could use the S_OR macro here</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19658/comment/83d3e878_ae36cd6e">Patch Set #1, Line 570:</a> <code style="font-family:monospace,monospace">static int load_config(void)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">It might be more logical to return 0 on success and 1 on failure, instead of 1 on success as you do here.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19658/comment/33d62b36_4eceb040">Patch Set #1, Line 578:</a> <code style="font-family:monospace,monospace"> if (cfg == CONFIG_STATUS_FILEMISSING) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">There should be some log message here (perhaps NOTICE) that the file is missing, otherwise there won't be any message as to why the module declined to load</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19658/comment/7a8bddfc_1732a8de">Patch Set #1, Line 592:</a> <code style="font-family:monospace,monospace"> if (strcasecmp(cat, "general") == 0) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">use !strcasecmp instead of == 0</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/19658">change 19658</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/19658"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 20 </div>
<div style="display:none"> Gerrit-Change-Id: I2eb02ef44190e026716720419bcbdbcc8125777b </div>
<div style="display:none"> Gerrit-Change-Number: 19658 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Holger Hans Peter Freyther <automatic@freyther.de> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: N A <asterisk@phreaknet.org> </div>
<div style="display:none"> Gerrit-Attention: Holger Hans Peter Freyther <automatic@freyther.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 09 Dec 2022 13:22:14 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>