<p>Jaco Kroon has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/19547">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Build system: Avoid executable stack.<br><br>Found in res_geolocation, but I believe others may have similar issues,<br>thus not linking to a specific issue.<br><br>Essentially gcc doesn't mark the stack for being non-executable unless<br>it's compiling the source, this informs ld via gcc to mark the object as<br>not requiring an executable stack (which a binary blob obviously<br>doesn't).<br><br>Change-Id: I71bcc2fd1fe0c82a28b3257405d6f2b566fd9bfc<br>Signed-off-by: Jaco Kroon <jaco@uls.co.za><br>---<br>M Makefile.rules<br>1 file changed, 20 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/47/19547/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/Makefile.rules b/Makefile.rules</span><br><span>index e6b6589..7b508e6 100644</span><br><span>--- a/Makefile.rules</span><br><span>+++ b/Makefile.rules</span><br><span>@@ -213,10 +213,10 @@</span><br><span> # extern const size_t _binary_abc_def_xml_size;</span><br><span> %.o: %.xml</span><br><span> $(ECHO_PREFIX) echo " [LD] $^ -> $@"</span><br><span style="color: hsl(0, 100%, 40%);">- $(CMD_PREFIX) $(CC) -g -nostartfiles -nodefaultlibs -nostdlib -r -Wl,-b,binary -o $@ $^</span><br><span style="color: hsl(120, 100%, 40%);">+ $(CMD_PREFIX) $(CC) -g -Wl,-znoexecstack -nostartfiles -nodefaultlibs -nostdlib -r -Wl,-b,binary -o $@ $^</span><br><span> </span><br><span> %.o: %.xslt</span><br><span> $(ECHO_PREFIX) echo " [LD] $^ -> $@"</span><br><span style="color: hsl(0, 100%, 40%);">- $(CMD_PREFIX) $(CC) -g -nostartfiles -nodefaultlibs -nostdlib -r -Wl,-b,binary -o $@ $^</span><br><span style="color: hsl(120, 100%, 40%);">+ $(CMD_PREFIX) $(CC) -g -Wl,-znoexecstack -nostartfiles -nodefaultlibs -nostdlib -r -Wl,-b,binary -o $@ $^</span><br><span> </span><br><span> dist-clean:: clean</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/19547">change 19547</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/19547"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: I71bcc2fd1fe0c82a28b3257405d6f2b566fd9bfc </div>
<div style="display:none"> Gerrit-Change-Number: 19547 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Jaco Kroon <jaco@uls.co.za> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>