<p> Attention is currently required from: N A, Joshua Colp, Alexei Gradinari, Stanislav Abramenkov. </p>
<p>Patch set 9:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/18830">View Change</a></p><p>5 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">Patchset:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18830?tab=comments">Patch Set #9:</a> </p><p style="white-space: pre-wrap; word-wrap: break-word;">Please rename the function to PJSIP_HEADER_PARAMS to be a bit more clear that it's not for setting core PJSIP parameters.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Move the code into res_pjsip_header_funcs.</p><p style="white-space: pre-wrap; word-wrap: break-word;">At the time this function would be called, have we already finalized the contents of the From header? I.E. has callerid been set along with any privacy requirements, has "from_domain" and "from_user" from the endpoint been applied? Does order matter when calling this function along with the CALLERID function?<br></p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File res/res_pjsip_parameters.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18830/comment/b5c1f2c7_ee40496a">Patch Set #9, Line 59:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> <parameter name="header_name" required="false"><br> <para>Header in which parameter should be read or set.</para><br> <para>Currently, the only supported header is <literal>From</literal>.</para><br> </parameter><br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Since you're implying that future headers may be supported, you should change this to "required". You should also re-order the parameters to be PJSIP_PARAM(header_name, parameter_type, parameter_name) and adjust the examples below.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18830/comment/aeaa4ec9_80287862">Patch Set #9, Line 89:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">static const struct ast_datastore_info param_datastore = {<br> .type = "param_datastore",<br>};<br><br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Not seeing where this is used anymore.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18830/comment/9f0d3799_a178b8b7">Patch Set #9, Line 172:</a> <code style="font-family:monospace,monospace"> dlg_info_uri = pjsip_uri_get_uri(dlg_info_name_addr);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Are you absolutely sure this will be a sip/sips uri?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18830/comment/614546b4_e0d21108">Patch Set #9, Line 187:</a> <code style="font-family:monospace,monospace">pjsip_param_add</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I know it's just a macro but can you rename this so it doesn't start with "pjsip_". In a debug situation, macro names can show up in coredumps.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/18830">change 18830</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/18830"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ifb1bc3c512ad5f6faeaebd7817f004a2ecbd6428 </div>
<div style="display:none"> Gerrit-Change-Number: 18830 </div>
<div style="display:none"> Gerrit-PatchSet: 9 </div>
<div style="display:none"> Gerrit-Owner: N A <asterisk@phreaknet.org> </div>
<div style="display:none"> Gerrit-Reviewer: Benjamin Keith Ford <bford@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean@seanbright.com> </div>
<div style="display:none"> Gerrit-CC: Alexei Gradinari <alex2grad@gmail.com> </div>
<div style="display:none"> Gerrit-CC: Stanislav Abramenkov <stas.abramenkov@gmail.com> </div>
<div style="display:none"> Gerrit-Attention: N A <asterisk@phreaknet.org> </div>
<div style="display:none"> Gerrit-Attention: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Attention: Alexei Gradinari <alex2grad@gmail.com> </div>
<div style="display:none"> Gerrit-Attention: Stanislav Abramenkov <stas.abramenkov@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 09 Nov 2022 13:15:09 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>