<p>N A has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/19468">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">app_voicemail: Fix missing email in msg_create_from_file.<br><br>msg_create_from_file currently does not dispatch emails,<br>which means that applications using this function, such<br>as MixMonitor, will not trigger notifications to users<br>(only AMI events are sent our currently). This is inconsistent<br>with other ways users can receive voicemail.<br><br>This is fixed by attempting to send an email and falling back<br>to just the notifications as done previously if we fail.<br><br>ASTERISK-30283 #close<br><br>Change-Id: I597cbb9cf971a18d8776172b26ab187dc096a5c7<br>---<br>M apps/app_voicemail.c<br>1 file changed, 40 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/68/19468/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/apps/app_voicemail.c b/apps/app_voicemail.c</span><br><span>index 510e15d..10e6f9e 100644</span><br><span>--- a/apps/app_voicemail.c</span><br><span>+++ b/apps/app_voicemail.c</span><br><span>@@ -6418,6 +6418,11 @@</span><br><span>         * to do both with one line and is also safe to use with file storage mode. Also, if we are using ODBC, now is a good</span><br><span>         * time to create the voicemail database entry. */</span><br><span>   if (ast_fileexists(destination, NULL, NULL) > 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+         struct ast_channel *chan;</span><br><span style="color: hsl(120, 100%, 40%);">+             char fmt[80];</span><br><span style="color: hsl(120, 100%, 40%);">+         char clid[80];</span><br><span style="color: hsl(120, 100%, 40%);">+                char cidnum[80], cidname[80];</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>              if (ast_check_realtime("voicemail_data")) {</span><br><span>                        get_date(date, sizeof(date));</span><br><span>                        ast_store_realtime("voicemail_data",</span><br><span>@@ -6437,7 +6442,21 @@</span><br><span>              }</span><br><span> </span><br><span>                STORE(dir, recipient->mailbox, recipient->context, msgnum, NULL, recipient, fmt, 0, vms, "", msg_id);</span><br><span style="color: hsl(0, 100%, 40%);">-           notify_new_state(recipient);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+                /* Send an email if possible, fall back to just notifications if not. */</span><br><span style="color: hsl(120, 100%, 40%);">+              ast_copy_string(fmt, recdata->recording_ext, sizeof(fmt));</span><br><span style="color: hsl(120, 100%, 40%);">+         ast_copy_string(clid, recdata->call_callerid, sizeof(clid));</span><br><span style="color: hsl(120, 100%, 40%);">+               ast_callerid_split(clid, cidname, sizeof(cidname), cidnum, sizeof(cidnum));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+         /* recdata->call_callerchan itself no longer exists, so we can't use the real channel. Use a dummy one. */</span><br><span style="color: hsl(120, 100%, 40%);">+             chan = ast_dummy_channel_alloc();</span><br><span style="color: hsl(120, 100%, 40%);">+             if (chan) {</span><br><span style="color: hsl(120, 100%, 40%);">+                   notify_new_message(chan, recipient, NULL, msgnum, duration, fmt, cidnum, cidname, "");</span><br><span style="color: hsl(120, 100%, 40%);">+                      ast_channel_unref(chan);</span><br><span style="color: hsl(120, 100%, 40%);">+              } else {</span><br><span style="color: hsl(120, 100%, 40%);">+                      ast_log(LOG_WARNING, "Failed to allocate dummy channel, email will not be sent\n");</span><br><span style="color: hsl(120, 100%, 40%);">+                 notify_new_state(recipient);</span><br><span style="color: hsl(120, 100%, 40%);">+          }</span><br><span>    }</span><br><span> </span><br><span>        free_user(recipient);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/19468">change 19468</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/19468"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I597cbb9cf971a18d8776172b26ab187dc096a5c7 </div>
<div style="display:none"> Gerrit-Change-Number: 19468 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: N A <asterisk@phreaknet.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>