<p> Attention is currently required from: Joshua Colp, N A, George Joseph. </p>
<p><a href="https://gerrit.asterisk.org/c/asterisk/+/18990">View Change</a></p><p>17 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">Patchset:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18990?tab=comments">Patch Set #8:</a> </p><p style="white-space: pre-wrap; word-wrap: break-word;">Thanks, done.<br>For some reasons the Jenkins failed to build the patch set. I have re-uploaded it again but the same result. I was not able to find a meaningful log output that gives a clue about the error (at least not for me).<br>It just silently fails after this:</p><p style="white-space: pre-wrap; word-wrap: break-word;">20:41:17 +--------- Asterisk Build Complete ---------+<br>20:41:17 + Asterisk has successfully been built, and +<br>20:41:17 + can be installed by running: +<br>20:41:17 + +<br>20:41:17 + make install +<br>20:41:17 +-------------------------------------------+<br>20:41:17 + rm -f 'tests/CI/output/UnitTests/lcov/*.info'<br>20:41:17 ++ alembic -c config.ini.sample branches<br>20:41:18 Alembic branches were found for config<br>20:41:18 539f68bede2c (branchpoint) -> 417c0247fd7e (head) -> ccf795ee535f (head)</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File configs/samples/pjsip.conf.sample:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18990/comment/bc96a31d_82b784ae">Patch Set #6, Line 1286:</a> <code style="font-family:monospace,monospace">;all_codecs_on_empty_reinvite=yes</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">This should state what the default behavior is.</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18990/comment/c6ff0fe2_b9e59069">Patch Set #6, Line 1287:</a> <code style="font-family:monospace,monospace"> ; On reception of a re-INVITE without SDP Asterisk will send an SDP</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">You should indicate the default value.</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File doc/CHANGES-staging/res_pjsip_all_codecs_on_empty_reinvite_option.txt:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18990/comment/2efc834f_efcff8ae">Patch Set #6, Line 3:</a> <code style="font-family:monospace,monospace">A new option named "all_codecs_on_empty_reinvite" has been added to the</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">You should indicate the default value.</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File res/res_pjsip/config_global.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18990/comment/6b349618_f379ae5a">Patch Set #6, Line 57:</a> <code style="font-family:monospace,monospace">#define DEFAULT_ALL_CODECS_ON_EMPTY_REINVITE 1</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Default behavior should remain as it was.</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18990/comment/4e923b1b_2f163ced">Patch Set #6, Line 57:</a> <code style="font-family:monospace,monospace">#define DEFAULT_ALL_CODECS_ON_EMPTY_REINVITE 1</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">I think the default should be 0 to preserve existing behavior.</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File res/res_pjsip/pjsip_config.xml:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18990/comment/fa9f2631_ab2048d1">Patch Set #6, Line 2104:</a> <code style="font-family:monospace,monospace">yes</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Should be "no".</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18990/comment/ba9b730d_8dd09ca8">Patch Set #6, Line 2104:</a> <code style="font-family:monospace,monospace"> <configOption name="all_codecs_on_empty_reinvite" default="yes"></code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Default should be no.</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File res/res_pjsip_session.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18990/comment/85349789_b9d88a89">Patch Set #6, Line 5078:</a> <code style="font-family:monospace,monospace">1</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Since the SCOPE_ENTER for this function uses level 3, this should be either -1 to use the same level […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18990/comment/950705b6_9e842928">Patch Set #6, Line 5081:</a> <code style="font-family:monospace,monospace">1</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">same</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18990/comment/42d1bc94_1147b793">Patch Set #6, Line 5085:</a> <code style="font-family:monospace,monospace">1</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">same</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18990/comment/52a8a8e6_23db4a94">Patch Set #6, Line 5087:</a> <code style="font-family:monospace,monospace">1</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">same</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18990/comment/0cc2f657_e97e7411">Patch Set #6, Line 5244:</a> <code style="font-family:monospace,monospace"> ast_trace(1, "session_inv_on_create_offer\n");</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">You don't need an ast_trace here since the SCOPE_ENTER prints the same message. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18990/comment/7322cf63_f8e27744">Patch Set #6, Line 5246:</a> <code style="font-family:monospace,monospace"> return;</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Replace this return with SCOPE_EXIT_RTN("%s: No channel\n", ast_sip_session_get_name(session)); SCO […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18990/comment/e59c72ef_2b776b14">Patch Set #6, Line 5256:</a> <code style="font-family:monospace,monospace">1</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">See above comment about trace level.</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18990/comment/5a3618bd_8b0f04a8">Patch Set #6, Line 5259:</a> <code style="font-family:monospace,monospace">1</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Same</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18990/comment/0cdf1286_3e320675">Patch Set #6, Line 5279:</a> <code style="font-family:monospace,monospace"> return;</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">You can remove the return since that's what SCOPE_EXIT_RTN does.</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/18990">change 18990</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/18990"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: I69763708d5039d512f391e296ee8a4d43a1e2148 </div>
<div style="display:none"> Gerrit-Change-Number: 18990 </div>
<div style="display:none"> Gerrit-PatchSet: 8 </div>
<div style="display:none"> Gerrit-Owner: Henning Westerholt <hw@gilawa.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Attention: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Attention: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Attention: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 10 Oct 2022 18:47:03 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Comment-In-Reply-To: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>