<p> Attention is currently required from: Frederic LE FOLL. </p>
<p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ddd; color: #000000;">-Code-Review</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/19409">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">Commit Message:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19409/comment/997dee92_483bba03">Patch Set #1, Line 7:</a> <code style="font-family:monospace,monospace">Dialing API: Cancel a running async thread, may not cancel all calls</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">The problem occurs in main/dial.c, aka "Dialing API" according to dial.h. Not in app_dial. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Ah, sorry, I misread "main/dial.c" as "app_dial.c" in the file list. You can ignore that.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Convention wise though using "dial" or "dial.c" might adhere to the commit message guidelines better but it's be less clear cut (lowercase, typically the name of the module or file)</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/19409">change 19409</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/19409"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 18 </div>
<div style="display:none"> Gerrit-Change-Id: Idbdd5c15122159661aa8e996a42d5800083131e4 </div>
<div style="display:none"> Gerrit-Change-Number: 19409 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Frederic LE FOLL <frederic.lefoll@csgroup.eu> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Attention: Frederic LE FOLL <frederic.lefoll@csgroup.eu> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 06 Oct 2022 17:18:31 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Comment-In-Reply-To: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Comment-In-Reply-To: Frederic LE FOLL <frederic.lefoll@csgroup.eu> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>