<p> Attention is currently required from: N A. </p>
<p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/18975">View Change</a></p><p>6 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">File apps/app_broadcast.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18975/comment/3dff03fd_3a10777e">Patch Set #2, Line 363:</a> <code style="font-family:monospace,monospace">            if ((mac = ast_calloc(1, sizeof(*mac)))) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Reduce indentation, if this fails then just unref and continue</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18975/comment/2a3ddbcf_08943035">Patch Set #2, Line 366:</a> <code style="font-family:monospace,monospace">                     if (!mac->name || !mac->autochan) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Same here, reduce indentation</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18975/comment/3e0c83c1_1d8fb409">Patch Set #2, Line 414:</a> <code style="font-family:monospace,monospace">       while (numchans && ast_waitfor(chan, 1000) > 0) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Where does the 1000 come from?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18975/comment/f9bae43a_d19d5d1a">Patch Set #2, Line 525:</a> <code style="font-family:monospace,monospace"></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This should store the old format, and then return the channel to it after do_broadcast.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18975/comment/f5b3a6ec_d5e82650">Patch Set #2, Line 538:</a> <code style="font-family:monospace,monospace"> int res = 0;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">There is no need for res here</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18975/comment/22d9adbc_89d1ab91">Patch Set #2, Line 547:</a> <code style="font-family:monospace,monospace">    int res = 0;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Same here</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/18975">change 18975</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/18975"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I7ba72f765dbab9b58deeae028baca3f4f8377726 </div>
<div style="display:none"> Gerrit-Change-Number: 18975 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Attention: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 27 Sep 2022 11:29:40 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>