<p> Attention is currently required from: Sean Bright, Mark Murawski. </p>
<p>Patch set 15:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/17655">View Change</a></p><p>19 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">File funcs/func_groupcount.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/17655/comment/efb26348_9c503f29">Patch Set #14, Line 795:</a> <code style="font-family:monospace,monospace"></code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">I don't follow this one... […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I don't mean what you did above aligning the variable definitions, I mean proper indentation in general.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File funcs/func_groupcount.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/17655/comment/1612d994_277c70b7">Patch Set #15, Line 792:</a> <code style="font-family:monospace,monospace"> if (group_or_regex[0] == '/') {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">For example, this should be indented one level from the line above.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/17655/comment/1a714028_7bf77d81">Patch Set #15, Line 813:</a> <code style="font-family:monospace,monospace"> else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">The else should go on the same line as the closing brace above.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/17655/comment/0e5fbab7_f3e188d8">Patch Set #15, Line 818:</a> <code style="font-family:monospace,monospace"> if (!ast_strlen_zero(category_or_regex)) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Same here</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/17655/comment/045b1194_4627ec1c">Patch Set #15, Line 842:</a> <code style="font-family:monospace,monospace"> else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Same here</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/17655/comment/368a5b95_403d1688">Patch Set #15, Line 890:</a> <code style="font-family:monospace,monospace"> if (group_regex_string) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Unindent</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/17655/comment/dc526a63_cb6d6762">Patch Set #15, Line 895:</a> <code style="font-family:monospace,monospace"> if (category_regex_string) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This should be unindented one level</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/17655/comment/d82c2f76_edbc5211">Patch Set #15, Line 908:</a> <code style="font-family:monospace,monospace"></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Here is another indentation messup: these 2 lines should be unindented one level. Also they are using spaces, not tabs, that needs to be fixed.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/17655/comment/f63a2b2f_cb5a3de4">Patch Set #15, Line 922:</a> <code style="font-family:monospace,monospace"> if (!ast_strlen_zero(group_or_regex)) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">ditto</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/17655/comment/65012d49_4a84809d">Patch Set #15, Line 944:</a> <code style="font-family:monospace,monospace"> else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">ditto</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/17655/comment/a10cdc10_2b58677c">Patch Set #15, Line 949:</a> <code style="font-family:monospace,monospace"> if (!ast_strlen_zero(category_or_regex)) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">ditto</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/17655/comment/735936ee_08004754">Patch Set #15, Line 973:</a> <code style="font-family:monospace,monospace"> else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">ditto</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/17655/comment/83dca81f_b2b9ea53">Patch Set #15, Line 1022:</a> <code style="font-family:monospace,monospace"> if (group_regex_string) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">ditto</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/17655/comment/97dff981_67e8df0f">Patch Set #15, Line 1027:</a> <code style="font-family:monospace,monospace"> if (category_regex_string) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">ditto</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/17655/comment/e0f2c158_879dca29">Patch Set #15, Line 1168:</a> <code style="font-family:monospace,monospace"> else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">ditto</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/17655/comment/3d633ce1_c7e610b2">Patch Set #15, Line 1394:</a> <code style="font-family:monospace,monospace"> strncpy(buf, ast_str_buffer(out), len);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Could we use ast_copy_string instead of strncpy?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File main/app.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/17655/comment/5dd59365_b2c4f720">Patch Set #15, Line 2490:</a> <code style="font-family:monospace,monospace"> </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">spaces/tabs and alignment</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/17655/comment/4ee9eb8f_9fa88d83">Patch Set #15, Line 2501:</a> <code style="font-family:monospace,monospace"></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">You are using spaces here, not tabs</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/17655/comment/ed87b101_503ac947">Patch Set #15, Line 2618:</a> <code style="font-family:monospace,monospace"></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">WHOLE function: spaces/tabs and alginment<br>I'm going to stop reviewing here, fix the rest of this file</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/17655">change 17655</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/17655"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 18 </div>
<div style="display:none"> Gerrit-Change-Id: I23e48d1cdfc8adaffdfec2e936e56143603914f2 </div>
<div style="display:none"> Gerrit-Change-Number: 17655 </div>
<div style="display:none"> Gerrit-PatchSet: 15 </div>
<div style="display:none"> Gerrit-Owner: Mark Murawski <markm@intellasoft.net> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean@seanbright.com> </div>
<div style="display:none"> Gerrit-Attention: Sean Bright <sean@seanbright.com> </div>
<div style="display:none"> Gerrit-Attention: Mark Murawski <markm@intellasoft.net> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 26 Sep 2022 16:50:04 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Comment-In-Reply-To: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Comment-In-Reply-To: Mark Murawski <markm@intellasoft.net> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>