<p><a href="https://gerrit.asterisk.org/c/asterisk/+/19059">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">Patchset:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19059?tab=comments">Patch Set #1:</a> </p><p style="white-space: pre-wrap; word-wrap: break-word;">As expected, test_resolve_refresh_media_states failed as I changed the logic of resolve_refresh_media_states.</p><p style="white-space: pre-wrap; word-wrap: break-word;">I am wondering what the reasoning was to stop processing the refresh if the current active state differs from the pending active state. As I have stated in the commit message, I think the careful queuing and re-queuing of requests (mostly in sip_session_refresh()) should ensure that refreshs are sent in the order they are received.</p><p style="white-space: pre-wrap; word-wrap: break-word;">What the current logic results in is that if one of the queued refreshes changes the (current active) topology, then any other refresh in the queue is dropped because then delayed active differs from current active. I'm not sure if that is the desired behavior.</p><p style="white-space: pre-wrap; word-wrap: break-word;">To verify this PR I would have to change the resolve_refresh_media_state test as well.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/19059">change 19059</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/19059"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: Icd0703295271089057717006730b555b9a1d4e5a </div>
<div style="display:none"> Gerrit-Change-Number: 19059 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Maximilian Fridrich <m.fridrich@commend.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 08 Sep 2022 06:59:02 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>