<p> Attention is currently required from: Sean Bright, Joshua Colp, Alexei Gradinari. </p>
<p><a href="https://gerrit.asterisk.org/c/asterisk/+/18824">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">Patchset:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18824?tab=comments">Patch Set #3:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">My original comment was marked resolved but it has not been. So the same comments as before really: […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I responded to your comment before, and there was no follow up answer.</p><p style="white-space: pre-wrap; word-wrap: break-word;">I don't see the point in allowing filtering on *anything*. Asterisk only supports the provided methods, so what's the point in allowing somebody to filter on a "FOOBAR" method? Nobody in the real world would do that. In that case, they can enable the full logger, in the 0.0000001% chance that they need to look at methods that Asterisk doesn't even support. I can just see somebody misspelling something like "SUBSRCIBE" and wondering why it's not working, since no error was thrown.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Moreover, the current implementation is very fast. Doing string comparisons will hurt performance.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Also, right now we have tab completion, which I think users will appreciate.</p><p style="white-space: pre-wrap; word-wrap: break-word;">For those reasons, I feel a vector of user provided strings makes less sense.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/18824">change 18824</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/18824"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Idd03bd9b466b40e4bca7769437d52ac13a957cf9 </div>
<div style="display:none"> Gerrit-Change-Number: 18824 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Reviewer: Alexei Gradinari <alex2grad@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean@seanbright.com> </div>
<div style="display:none"> Gerrit-Attention: Sean Bright <sean@seanbright.com> </div>
<div style="display:none"> Gerrit-Attention: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Attention: Alexei Gradinari <alex2grad@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 05 Sep 2022 15:08:31 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: Sean Bright <sean@seanbright.com> </div>
<div style="display:none"> Comment-In-Reply-To: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Comment-In-Reply-To: Alexei Gradinari <alex2grad@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>