<p> Attention is currently required from: Henning Westerholt. </p>
<p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/18990">View Change</a></p><p>6 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">Commit Message:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18990/comment/e44908b8_186da31c">Patch Set #2, Line 8:</a> <code style="font-family:monospace,monospace"></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Wrap commit message at 72 characters to avoid wrapping</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File configs/samples/pjsip.conf.sample:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18990/comment/629f87bd_42457d1e">Patch Set #2, Line 1281:</a> <code style="font-family:monospace,monospace"> ; If we should return all codecs on empty re-INVITE.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I don't think "If we should" is necessary, and just starting with "Return" is clearer to me. Either that or "Whether to return..."</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18990/comment/028f6070_4e885667">Patch Set #2, Line 1282:</a> <code style="font-family:monospace,monospace"> ; RFC 3261 specify it SHOULD be done like this.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">specifies</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File include/asterisk/res_pjsip.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18990/comment/79c622ae_6f8ab018">Patch Set #2, Line 3505:</a> <code style="font-family:monospace,monospace"> * \since unreleased</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I don't think \since unreleased is needed</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File res/res_pjsip/pjsip_config.xml:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18990/comment/43867641_9b310c04">Patch Set #2, Line 2078:</a> <code style="font-family:monospace,monospace"> specify this as a SHOULD requirement.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">specifies</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File res/res_pjsip_session.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18990/comment/492eadff_a5153633">Patch Set #2, Line 5231:</a> <code style="font-family:monospace,monospace"> ast_trace(-1, "session_inv_on_create_offer\n");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Should the -1 be 1?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/18990">change 18990</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/18990"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: I69763708d5039d512f391e296ee8a4d43a1e2148 </div>
<div style="display:none"> Gerrit-Change-Number: 18990 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Henning Westerholt <hw@gilawa.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Attention: Henning Westerholt <hw@gilawa.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 26 Aug 2022 13:42:43 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>