<p> Attention is currently required from: Michael Bradeen, Joshua Colp. </p>
<p>Patch set 4:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/testsuite/+/18962">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">Patchset:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/testsuite/+/18962?tab=comments">Patch Set #4:</a> </p><p style="white-space: pre-wrap; word-wrap: break-word;">I think you missed tests/codecs/rtp_analyzer.py.  Do you have codec_opus installed?</p><p style="white-space: pre-wrap; word-wrap: break-word;">File "/usr/src/asterisk/testsuite/tests/codecs/rtp_analyzer.py", line 65, in __init__<br>pcap_config = dict(pcap_defaults.items() + module_config.items())<br>TypeError: unsupported operand type(s) for +: 'dict_items' and 'dict_items'</p><p style="white-space: pre-wrap; word-wrap: break-word;">For python 3, it should be<br>pcap_config = dict(pcap_defaults, **module_config)</p><p style="white-space: pre-wrap; word-wrap: break-word;">Per my comment on the review for the asterisk part, we should move the venv creation here so the testsuite can be run directly.<br></p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File tests/channels/pjsip/transfers/attended_transfer/nominal/callee_local_direct_media/test-config.yaml:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/testsuite/+/18962/comment/c564e3d8_508bd1d7">Patch Set #4, Line 1:</a> <code style="font-family:monospace,monospace">testinfo:</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This test always fails for me...</p><p style="white-space: pre-wrap; word-wrap: break-word;">Running tests/channels/pjsip/transfers/attended_transfer/nominal/caller_local_direct_media ...<br>[Aug 22 05:52:04] WARNING[3775069]: asterisk.sipp:572 processEnded: b"Resolving remote host '127.0.0.1'... Done.n"<br>[Aug 22 05:52:04] WARNING[3775069]: asterisk.sipp:572 processEnded: b'2022-08-22t05:52:04.186904t1661169124.186904: sendCmdBuffer returned -1nThere were more errors, enable -trace_err to log them.n'<br>[Aug 22 05:52:04] WARNING[3775069]: asterisk.sipp:675 __scenario_callback: SIPp Scenario referer.xml Failed [1]<br>[Aug 22 05:52:04] WARNING[3775069]: asterisk.sipp:849 __scenario_callback: Coordinated SIPp Scenario 5080 Failed<br>[Aug 22 05:52:04] WARNING[3775069]: asterisk.sipp:684 __evaluate_scenario_results: SIPp Scenario referer.xml Failed<br>[Aug 22 05:52:04] WARNING[3775069]: asterisk.sipp:536 kill: Killing SIPp Scenario wait-for-a-call.xml<br>[Aug 22 05:52:04] WARNING[3775069]: asterisk.sipp:536 kill: Killing SIPp Scenario wait-for-a-call-then-send-bye.xml<br>[Aug 22 05:52:04] WARNING[3775069]: asterisk.sipp:231 _handle_scenario_finished: Scenario Coordinated Scenario 5080 failed<br>[Aug 22 05:52:49] WARNING[3775069]: asterisk.asterisk:598 __send_kill: Sending KILL to Asterisk 127.0.0.1<br>Test tests/channels/pjsip/transfers/attended_transfer/nominal/caller_local_direct_media failed</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/testsuite/+/18962">change 18962</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/testsuite/+/18962"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: testsuite </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: Id22c8f7a89e2d00fca760970af63f3954c049bf3 </div>
<div style="display:none"> Gerrit-Change-Number: 18962 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: Michael Bradeen <mbradeen@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Attention: Michael Bradeen <mbradeen@sangoma.com> </div>
<div style="display:none"> Gerrit-Attention: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 22 Aug 2022 12:10:10 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>