<p> Attention is currently required from: Joshua Colp, N A. </p>
<p><a href="https://gerrit.asterisk.org/c/asterisk/+/18837">View Change</a></p><p>11 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">File res/res_pjsip/security_agreements.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18837/comment/107c433c_46ab75b4">Patch Set #4, Line 37:</a> <code style="font-family:monospace,monospace"> mech = ast_malloc(sizeof(struct ast_sip_security_mechanism));</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">If you use calloc then it will be automatically zeroed out.</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18837/comment/a3b40b7f_ace5976c">Patch Set #4, Line 44:</a> <code style="font-family:monospace,monospace"> ast_free(mech);</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Indentation</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18837/comment/c173b69c_97375e7b">Patch Set #4, Line 60:</a> <code style="font-family:monospace,monospace"> dst = ast_sip_security_mechanisms_alloc(n_params);</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">This can fail</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18837/comment/72538985_0d4ce3d6">Patch Set #4, Line 89:</a> <code style="font-family:monospace,monospace"> if (AST_VECTOR_SIZE(dst) != 0) {</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Indentation</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File res/res_pjsip_outbound_registration.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18837/comment/8e75e08b_b36154f3">Patch Set #4, Line 596:</a> <code style="font-family:monospace,monospace"> (aor = ast_sip_location_retrieve_aor(endpt->aors)) &&</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">What happens if there are multiple AORs and contacts? The behavior should be documented somewhere</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Your comment made me realize that the endpoint would be the better place to store this information, so I refactored it and store the server security mechanisms in the endpoint now. The many-to-many relationships between endpoint and aors, and aors and contacts were a huge drawback.</p><p style="white-space: pre-wrap; word-wrap: break-word;">The sip_session_supplement called on outgoing requests via this outbound registration are called with this endpoint, so it works.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18837/comment/7a733961_ca98d96c">Patch Set #4, Line 609:</a> <code style="font-family:monospace,monospace"> if (client_state->status == SIP_REGISTRATION_REGISTERED || client_state->status == SIP_REGISTRATION_REJECTED_TEMPORARY </code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Redness</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18837/comment/1f3ac888_a3cf74ec">Patch Set #4, Line 632:</a> <code style="font-family:monospace,monospace"> ao2_ref(endpt, -1);</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Use ao2_cleanup</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18837/comment/b87136c6_6eda6241">Patch Set #4, Line 635:</a> <code style="font-family:monospace,monospace"> ao2_ref(reg, -1);</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Use ao2_cleanup</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18837/comment/2285591e_2ffa5238">Patch Set #4, Line 1113:</a> <code style="font-family:monospace,monospace"> if (endpt) {</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Same applies here as above</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File res/res_pjsip_rfc3329.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18837/comment/eb7988fd_83563ed6">Patch Set #4, Line 74:</a> <code style="font-family:monospace,monospace"> if (contact_status) {</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">It's impossible for contact_status to be NULL here</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Refactored. contact_status is no longer used.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18837/comment/06d23a12_b6555c2b">Patch Set #4, Line 110:</a> <code style="font-family:monospace,monospace"> if (contact_status) {</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">It's impossible for contact_status to be NULL here</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Refactored. contact_status is no longer used.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/18837">change 18837</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/18837"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: Ia7f5b5ba42db18074fdd5428c4e1838728586be2 </div>
<div style="display:none"> Gerrit-Change-Number: 18837 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: Maximilian Fridrich <m.fridrich@commend.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Attention: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Attention: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 18 Aug 2022 12:03:15 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>