<p> Attention is currently required from: Sean Bright, N A, Joshua Colp. </p>
<p><a href="https://gerrit.asterisk.org/c/asterisk/+/18829">View Change</a></p><p>9 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">Patchset:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18829?tab=comments">Patch Set #22:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Why do we no longer support unload?? […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Ack</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">Patchset:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18829?tab=comments">Patch Set #23:</a> </p><p style="white-space: pre-wrap; word-wrap: break-word;">Patchset 23:</p><p style="white-space: pre-wrap; word-wrap: break-word;">reworked module load to only load dialplan functions if subscription to status updates succeeded.</p><p style="white-space: pre-wrap; word-wrap: break-word;">removed unnecessary is_enabled() in each of the Dialplan functions, as if the module isn't enabled then the dialplan functions are not registered.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File configs/samples/hiredis.conf.sample:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18829/comment/03173d07_e8fbd295">Patch Set #22, Line 2:</a> <code style="font-family:monospace,monospace">enabled = yes ; When set to yes, hiredis support is enabled, default = no</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Since this is uncommented, this would default enable the support for anyone loading the module. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">enabled = yes now commented out, so default of no kicks in.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18829/comment/d9e6d1c3_6b9e49f2">Patch Set #22, Line 7:</a> <code style="font-family:monospace,monospace">prefix = pabx: ; Prefix to prepend to all keypaths, default = ""</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">I'm assuming PABX = Private Automatic Branch Exchange? Just seems like an odd prefix choice in a sam […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Depends, not from our point of view.</p><p style="white-space: pre-wrap; word-wrap: break-word;">I've renamed it to 'asterisk', but depends on what else is feeding the Redis Server</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18829/comment/97c80742_aba020e0">Patch Set #22, Line 11:</a> <code style="font-family:monospace,monospace">background_save_on_unload = yes ; When set to yes, initiate a Background save when unloading module, default=no</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">So you indicated you remove the unload option but this is still here - would this still be relevant?</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Missed that, thanks.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18829/comment/c7b6ec54_c776bff8">Patch Set #22, Line 15:</a> <code style="font-family:monospace,monospace">;password = 12345678 ; default = "", no authentication</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">The other lines are indented using spaces but this uses tabs so the alignment is off</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File res/res_hiredis.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18829/comment/c3f41c99_3cab48f5">Patch Set #20, Line 919:</a> <code style="font-family:monospace,monospace"> device_state_sub = stasis_subscribe(ast_device_state_topic_all(), device_state_cb, NULL);</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">If this fails then this isn't going to work, and will confuse.</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">reworked, only is the subscription succeeds does it then load the dialplan functions</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File res/res_hiredis.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18829/comment/1a76ff6c_78fda06f">Patch Set #22, Line 54:</a> <code style="font-family:monospace,monospace"> <example></code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">The examples should have titles for each one that describe what they do, e.g. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">The synopsis already explains that.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18829/comment/eb2747bd_b31a81e6">Patch Set #22, Line 854:</a> <code style="font-family:monospace,monospace"> return -1;</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">In that case, I think it should at least be documented (e.g. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/18829">change 18829</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/18829"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ifdf4d33d2a2a5fd044fac13b201c7437de34ba6a </div>
<div style="display:none"> Gerrit-Change-Number: 18829 </div>
<div style="display:none"> Gerrit-PatchSet: 23 </div>
<div style="display:none"> Gerrit-Owner: Alec Davis <alec@bdt.co.nz> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean@seanbright.com> </div>
<div style="display:none"> Gerrit-Attention: Sean Bright <sean@seanbright.com> </div>
<div style="display:none"> Gerrit-Attention: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Attention: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Sat, 06 Aug 2022 01:35:00 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Comment-In-Reply-To: Alec Davis <alec@bdt.co.nz> </div>
<div style="display:none"> Comment-In-Reply-To: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>