<p> Attention is currently required from: N A, Joshua Colp, George Joseph. </p>
<p><a href="https://gerrit.asterisk.org/c/asterisk/+/18830">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">File doc/CHANGES-staging/res_pjsip_session_params.txt:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18830/comment/a73b50b2_ee257f98">Patch Set #1, Line 5:</a> <code style="font-family:monospace,monospace">SIPURIPARAMETERS variable on a channel</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I thought that in PJSIP we are moving away from using channel variables in favor of functions.</p><p style="white-space: pre-wrap; word-wrap: break-word;">1. The name SIPURIPARAMETERS does not explain that asterisk adds the URI parameters only into From header. What if needed to add into To header?</p><p style="white-space: pre-wrap; word-wrap: break-word;">2. I think that it would be more correct to do this through a function like PJSIP_HEADER<br>For example:<br>PJSIP_HEADER_URI_PARAMETER(header_name,action,name)<br>where action could be 'read', 'add', 'update' or 'remove'.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Examples:</p><p style="white-space: pre-wrap; word-wrap: break-word;">; to get isup-oli parameter<br>exten => 1,1,Set(isup_oli=${PJSIP_HEADER_URI_PARAMETER(From,read,isup-oli)})</p><p style="white-space: pre-wrap; word-wrap: break-word;">; to set isup-oli parameter<br>exten => 1,1,Set(PJSIP_HEADER_URI_PARAMETER(From,set,isup-oli)=1234567)</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/18830">change 18830</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/18830"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ifb1bc3c512ad5f6faeaebd7817f004a2ecbd6428 </div>
<div style="display:none"> Gerrit-Change-Number: 18830 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean@seanbright.com> </div>
<div style="display:none"> Gerrit-CC: Alexei Gradinari <alex2grad@gmail.com> </div>
<div style="display:none"> Gerrit-Attention: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Attention: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Attention: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 25 Jul 2022 22:24:56 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>