<p> Attention is currently required from: Alec Davis, N A. </p>
<p>Patch set 4:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/18829">View Change</a></p><p>13 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">Commit Message:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18829/comment/72f0d55e_6fc1b493">Patch Set #4, Line 7:</a> <code style="font-family:monospace,monospace">revert deleted files that create 10000 lines of change</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">The commit message should go back to the way it was.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File configs/samples/redisd.conf.sample:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18829/comment/55fa9e39_40ec766d">Patch Set #4, Line 2:</a> <code style="font-family:monospace,monospace">enabled = yes ; When set to yes, redisd support is enabled</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">What's the default?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File include/asterisk/redisd.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18829/comment/508a0d0c_76677d75">Patch Set #4, Line 30:</a> <code style="font-family:monospace,monospace">AST_OPTIONAL_API(void, ast_redisd_command, (const char *command, const char *key_path, const char *_keyvalue, char *return_buffer, size_t return_buffwe_len), {});</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This needs to be documented</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File res/res_redis_device_state.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18829/comment/35a82351_d5feb335">Patch Set #4, Line 49:</a> <code style="font-family:monospace,monospace"> char return_buffer[4096];</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Why 4096?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18829/comment/c61dd304_c0c6d1b7">Patch Set #4, Line 69:</a> <code style="font-family:monospace,monospace"> ast_debug(6, "device length zero\n");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Is it possible for this to happen?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18829/comment/ef3fe8c6_4f74e17f">Patch Set #4, Line 78:</a> <code style="font-family:monospace,monospace"> ast_str_set(&key_path, 0, "deviceState:%s", device);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This is easy to calculate as a fixed length, which means ast_str_alloca could be used instead of mallocing/freeing underneath.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18829/comment/4ea41ee0_8ba5d236">Patch Set #4, Line 96:</a> <code style="font-family:monospace,monospace"> device_state_sub = stasis_subscribe(ast_device_state_topic_all(), device_state_cb, NULL);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This can fail</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18829/comment/0c0f9367_e944f851">Patch Set #4, Line 97:</a> <code style="font-family:monospace,monospace"></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Filtering was added for stasis subscriptions to reduce the work done within dispatching, this is done by res_stasis_device_state for example for device state and should be done here as well.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18829/comment/c3c5a906_f55e99f3">Patch Set #4, Line 101:</a> <code style="font-family:monospace,monospace">AST_MODULE_INFO(ASTERISK_GPL_KEY, AST_MODFLAG_GLOBAL_SYMBOLS | AST_MODFLAG_LOAD_ORDER, "REDIS Device State support",</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Why does this export global symbols?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File res/res_redisd.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18829/comment/ea83baf5_8b5bceb7">Patch Set #4, Line 226:</a> <code style="font-family:monospace,monospace"> if (attempt++ < 3) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Should this be configurable?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18829/comment/076de79d_c337a940">Patch Set #4, Line 245:</a> <code style="font-family:monospace,monospace"> msg = ast_str_create(4096);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Why 4096? If you set it to a lower initial allocation, it will automatically grow as needed. You could also store it on the thread local storage instead and reuse it.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18829/comment/f95358ec_a44ceb1e">Patch Set #4, Line 287:</a> <code style="font-family:monospace,monospace"> strncpy(return_buffer, ast_str_buffer(msg), return_buffer_length);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Why not make a return buffer optional so the caller doesn't have to allocate one that they'll just end up ignoring?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18829/comment/50d2cefd_0e522270">Patch Set #4, Line 361:</a> <code style="font-family:monospace,monospace"> if (!(cfg = ao2_alloc(sizeof(*cfg), conf_destructor))) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">These two things don't need to be allocated with locks</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/18829">change 18829</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/18829"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ifdf4d33d2a2a5fd044fac13b201c7437de34ba6a </div>
<div style="display:none"> Gerrit-Change-Number: 18829 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: Alec Davis <alec@bdt.co.nz> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-CC: Sean Bright <sean@seanbright.com> </div>
<div style="display:none"> Gerrit-Attention: Alec Davis <alec@bdt.co.nz> </div>
<div style="display:none"> Gerrit-Attention: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 22 Jul 2022 14:21:09 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>