<p> Attention is currently required from: Alec Davis. </p>
<p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/18828">View Change</a></p><p>13 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">File configs/samples/redisd.conf.sample:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18828/comment/e42fe16b_5a12519e">Patch Set #1, Line 1:</a> <code style="font-family:monospace,monospace">[general]</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">The sample config is a little sparse, though maybe there isn't really much to say.<br>A small intro as to how this module can be configured might be nice.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File include/asterisk/redisd.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18828/comment/0d4dd357_199ddee3">Patch Set #1, Line 6:</a> <code style="font-family:monospace,monospace"> * David M. Lee, II <dlee@digium.com></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Copyright looks wrong? Is this file really his or yours?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File res/res_redis_device_state.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18828/comment/2daffb7d_2582ae4b">Patch Set #1, Line 4:</a> <code style="font-family:monospace,monospace"> * Copyright (C) 2005-2006, Digium, Inc.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Remove this - copyright is yours not Digium's</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18828/comment/de285944_02113dc6">Patch Set #1, Line 80:</a> <code style="font-family:monospace,monospace"> //throw away result</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Use /* comments */ only.<br>// comments don't exist in the C89 standard.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18828/comment/9e4dca6a_98208453">Patch Set #1, Line 81:</a> <code style="font-family:monospace,monospace"> char return_buffer[4096];</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Did you compile in developer mode? Mixed variables and declarations are *not* permitted.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File res/res_redisd.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18828/comment/92de0a42_0e3fd2e2">Patch Set #1, Line 4:</a> <code style="font-family:monospace,monospace"> * Copyright (C) 2005-2006, Digium, Inc.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Remove this. The copyright is yours, not Digium's.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18828/comment/6038ecfa_06d77b9e">Patch Set #1, Line 27:</a> <code style="font-family:monospace,monospace"> *</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">formatting seems messed up here?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18828/comment/d14cd04b_8d1acd22">Patch Set #1, Line 47:</a> <code style="font-family:monospace,monospace"></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">It seems like you're using spaces everywhere, not tabs.<br>Asterisk uses tabs, not spaces.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18828/comment/61e7e14b_b3efdc71">Patch Set #1, Line 58:</a> <code style="font-family:monospace,monospace"> <synopsis>Global configuration settings</synopsis></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">For modules that have default options, explicitly specify them here using the appropriate XML attributes.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18828/comment/454a5ee1_d3644f4f">Patch Set #1, Line 139:</a> <code style="font-family:monospace,monospace"> if (redisd_context == NULL) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">You could just do !redisd_context</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18828/comment/25c8ad3a_fda6b9b8">Patch Set #1, Line 168:</a> <code style="font-family:monospace,monospace"> ast_log(LOG_DEBUG, "Authenticated.\n");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Use ast_debug(level, fmt, ...) not ast_log(LOG_DEBUG, fmt, ...)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18828/comment/ddee27c8_6b28e8ed">Patch Set #1, Line 248:</a> <code style="font-family:monospace,monospace"> </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">redness (trailing whitespace)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18828/comment/510fd278_e6776f9c">Patch Set #1, Line 305:</a> <code style="font-family:monospace,monospace"> </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">redness</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/18828">change 18828</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/18828"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I17dc11b1d0b4d046a3f092ddf7778108dbcd1cce </div>
<div style="display:none"> Gerrit-Change-Number: 18828 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Alec Davis <alec@bdt.co.nz> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Attention: Alec Davis <alec@bdt.co.nz> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 21 Jul 2022 10:26:47 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>